Differential D13

INP-1383 - Don't translate phrase from "empty_label" parameter of "PedefinedOptions" tag twice
Needs ReviewPublic
Actions

Authored by erik on Sep 25 2014, 11:33 AM.

Details

Reviewers

alex

Test Plan

Edit core/admin_templates/promo_block_groups/promo_block_group_edit.tpl - add empty_label="la_Yes" attribute to the $prefix_PredefinedOptions tag (used for custom TransitionEffect field display).
Go to Website & Content -> Promo Blocks section in the adm.console.
Open "Default Group" for edit.
Click on "Promo Transition Effect" dropdown.
Confirm, that first value in dropdown is displayed as "Yes", not "!YES!".

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

erik updated this revision to Diff 18.Sep 25 2014, 11:33 AM

erik retitled this revision from to Duplicate empty_label translation.

erik updated this object.

erik edited the test plan for this revision. (Show Details)

erik added a reviewer: alex.

erik set the repository for this revision to rINP In-Portal.

erik added 1 JIRA issue(s): INP-1383.

Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.

alex retitled this revision from Duplicate empty_label translation to INP-1383 - Duplicate empty_label translation.Dec 7 2014, 3:32 PM

alex edited edge metadata.

alex set the repository for this revision to rINP In-Portal.Dec 7 2014, 3:41 PM

alex retitled this revision from INP-1383 - Duplicate empty_label translation to INP-1383 - Don't translate phrase from "empty_label" parameter of "PedefinedOptions" tag twice.Jul 16 2016, 7:28 AM

alex edited the test plan for this revision. (Show Details)

Missing test plan.

This revision now requires changes to proceed.Nov 27 2023, 2:15 AM

erik edited the test plan for this revision. (Show Details)Nov 27 2023, 5:21 AM

Written requested test plan

Revision Contents
Changeset List

			Path	Packages
M			core/kernel/db/db_tag_processor.php (8 lines)

Diff 18

View Options

core/kernel/db/db_tag_processor.php

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18			Sep 25 2014, 11:32 AM	★	★

INP-1383 - Don't translate phrase from "empty_label" parameter of "PedefinedOptions" tag twiceNeeds ReviewPublicActions