Page MenuHomeIn-Portal Phabricator

INP-1529 - Don't attach same file twice to same e-mail
ClosedPublic

Authored by alex on Jan 30 2016, 5:03 AM.

Details

Test Plan

Part 1

  1. go to Admin Console
  2. go to Website & ContentE-mail Templates section
  3. use Add toolbar button to open new e-mail template creation page
  4. on General tab enter following:
    • Template Name - TEST.EMAIL
    • Subject - Test Email Subject
    • HTML Version - <inp2:m_AttachFile path="favicon.ico"/>
  5. on Settings tab enter following:
    • Type - Admin
  6. press Save toolbar button
  7. click on ID column name to sort grid by id (will show newly created e-mail template)
  8. select just created e-mail template in grid
  9. press Send button on toolbar
  10. outside of In-Portal check administrator's e-mail account and confirm, that:
    • e-mail was received
    • e-mail has 1 attachment named favicon.ico

Part 2

  1. edit e-mail template by double clicking on it's record in grid
  2. put <inp2:m_AttachFile path="favicon.ico"/> into the Text Version textarea
  3. press Save toolbar button
  4. select that e-mail template in grid
  5. press Send button on toolbar
  6. outside of In-Portal check administrator's e-mail account and confirm, that:
    • e-mail was received
    • e-mail has 1 attachment named favicon.ico

Part 3

  1. edit e-mail template by double clicking on it's record in grid
  2. change value of path parameter of m_AttachFile tag in Text Version field to be CREDITS
  3. press Save toolbar button
  4. select that e-mail template in grid
  5. press Send button on toolbar
  6. outside of In-Portal check administrator's e-mail account and confirm, that:
    • e-mail was received
    • e-mail has 2 attachments that are named favicon.ico and CREDITS

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: The whole class has methods named like that for now.
SeverityLocationCodeMessage
Errorcore/kernel/utility/email_send.php:619PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCapsCodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
Unit
No Unit Test Coverage
Build Status
Buildable 325
Build 325: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 477.Jan 30 2016, 5:03 AM
alex retitled this revision from to INP-1529 - Don't attach same file twice to same e-mail.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1529.
alex edited the test plan for this revision. (Show Details)Jan 30 2016, 5:09 AM
alex edited edge metadata.
glebs accepted this revision.Feb 19 2016, 2:27 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Feb 19 2016, 2:27 AM
alex edited edge metadata.Mar 10 2016, 5:15 AM
alex added a project: Restricted Project.
This revision was automatically updated to reflect the committed changes.