Page MenuHomeIn-Portal Phabricator

INP-1577 - CS fix all variable type comment
ClosedPublic

Authored by alex on Aug 7 2016, 12:46 PM.

Details

Test Plan

Preparations

  1. make sure that no other files under VCS control are changed (even in different change lists) prior to applying the patch
  2. apply the patch via arc patch D240 command (usual stuff)
  3. run the composer install command in root folder of In-Portal
  4. ensure, that /tools/build/build.properties file is present (see Preparing Build Environment)
  5. open /tools/build/targets/common.xml file for editing in IDE
    • search for <arg value="--extensions=php"/>
    • after each found line add this line <arg value="--sniffs=CodingStandard.Commenting.TypeComment"/>
    • save changes

Plan

  • run phing -f tools/build/build_all.xml phpcs command
  • confirm, that no errors/warnings were found (the above command searches for them)
  • run phing -f tools/build/build_all.xml lint command
  • confirm, that no PHP files contain syntax errors (the above command searches for them)
  • look at made changes (in Phabricator)
  • confirm, that only type comments are fixed
  • confirm, that nothing else is changed/fixed

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: The `CodingStandard.Commenting.TypeComment` error only is fixed here.
SeverityLocationCodeMessage
Errorcore/install.php:387PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.NoLineBeforeOpenCodingStandard.WhiteSpace.ControlStructureSpacing.NoLineBeforeOpen
Errorcore/install.php:387PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/install.php:387PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/install.php:676PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.NoLineBeforeOpenCodingStandard.WhiteSpace.ControlStructureSpacing.NoLineBeforeOpen
Errorcore/install.php:676PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/install.php:676PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/install.php:696PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.NoLineBeforeOpenCodingStandard.WhiteSpace.ControlStructureSpacing.NoLineBeforeOpen
Errorcore/install.php:696PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/install.php:696PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/install.php:843PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errorcore/install.php:843PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errorcore/install.php:873PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errorcore/install.php:873PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errorcore/install.php:875PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/install.php:893PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errorcore/install.php:893PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errorcore/install.php:1028PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errorcore/install.php:1028PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errorcore/install.php:1033PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/install.php:1033PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/install.php:1060PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errorcore/install.php:1060PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errorcore/install.php:1061PHPCS.E.Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsedGeneric.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Errorcore/install.php:1062PHPCS.E.Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsedGeneric.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Errorcore/install/install_toolkit.php:531PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 653
Build 653: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 590.Aug 7 2016, 12:46 PM
alex retitled this revision from to INP-1577 - CS fix all variable type comment.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1577.
alex updated this revision to Diff 591.Aug 8 2016, 3:08 AM
alex edited edge metadata.
  1. added missing files:
    • application.php
    • widget_eh.php
  2. manually fixed errors, that can't be fixed automatically
alex edited the test plan for this revision. (Show Details)Aug 8 2016, 3:30 AM
alex edited the test plan for this revision. (Show Details)
alex added a comment.Aug 17 2016, 3:27 AM

@erik , please accept this revision, because associated JIRA task is accepted.

erik accepted this revision.Aug 19 2016, 4:29 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Aug 19 2016, 4:29 AM
alex updated this revision to Diff 686.Jan 20 2017, 6:55 AM
alex edited edge metadata.

Replaying fix after In-Portal 5.2.2-B1 release.

alex updated this revision to Diff 687.Jan 20 2017, 7:56 AM

Restoring manual fixes (from original patch), that were done after automatic fixes.

This revision was automatically updated to reflect the committed changes.