Page MenuHomeIn-Portal Phabricator

INP-1586 - Automatically update "ThemeId" field of category, when it's "Type" is changed
ClosedPublic

Authored by alex on Oct 20 2016, 10:39 AM.

Details

Test Plan

Preparations

  • in IDE:
    1. create /themes/advanced/test.tpl template
  • in Admin Console
    1. go to ConfigurationWebsiteThemes section
    2. press Rescan Themes toolbar button

Part 1

  1. login to Admin Console
  2. go to Website & ContentStructure & Data section
  3. confirm, that:
    1. category with _Auto: test name exists
    2. the _Auto: test category has test in Template column in grid
    3. the _Auto: test category has semi-transparent red icon (means not visible in menu + theme bound)
  4. open _Auto: test category for editing
  5. press Save button on toolbar
  6. confirm, that saving was successful
  7. open _Auto: test category for editing
  8. change value in Template File textbox from test into test_bad
  9. press Save button on toolbar
  10. confirm, that saving failed due validation error on Template File field is triggered about non-existing test_bad` template
  11. close editing window

Part 2

  1. login to Admin Console
  2. go to Website & ContentStructure & Data section
  3. delete _Auto: test category
  4. open Forums category (should have yellow icon in grid) for editing
  5. change category type from Virtual into Template
  6. specify test in Template File field
  7. press Save button on toolbar
  8. confirm, that saving was successful
  9. confirm, that saved category now has red icon in grid
  10. open Forums category (should have red icon in grid) for editing
  11. change value in Template File textbox from test into test_bad
  12. press Save button on toolbar
  13. confirm, that saving failed due validation error on Template File field is triggered about non-existing test_bad` template
  14. change category type from Template into Virtual
  15. specify in-bulletin/designs/section in Template dropdown
  16. press Save button on toolbar
  17. confirm, that saving was successful
  18. confirm, that saved category now has yellow icon in grid

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 602.Oct 20 2016, 10:39 AM
alex retitled this revision from to INP-1586 - Automatically update "ThemeId" field of category, when it's "Type" is changed.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1586.
alex edited edge metadata.Oct 20 2016, 10:39 AM
alex added a project: Restricted Project.
erik accepted this revision.Oct 21 2016, 4:08 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Oct 21 2016, 4:08 AM
alex planned changes to this revision.Nov 24 2016, 3:03 PM

This change introduces a bug, that results in non-validating Template field to be existing file unless I change Type field.

To fix IFs for setting ThemeId column must be extracted.

alex edited the test plan for this revision. (Show Details)Jan 20 2017, 5:22 AM
alex edited edge metadata.
alex updated this revision to Diff 684.Jan 20 2017, 5:24 AM
alex edited the test plan for this revision. (Show Details)

Fixing implementation issue, that caused Template File field to be validated only on category type change.

This revision is now accepted and ready to land.Jan 20 2017, 5:24 AM
alex requested a review of this revision.Jan 20 2017, 5:26 AM
alex edited edge metadata.
erik accepted this revision.Jan 23 2017, 4:12 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Jan 23 2017, 4:12 AM
This revision was automatically updated to reflect the committed changes.