Differential D251

INP-1587 - Change stylesheet URL for CKEditor to immediately return CSS
ClosedPublic
Actions

Authored by alex on Oct 21 2016, 8:35 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16475: Fixes INP-1587 - Change stylesheet URL for CKEditor to immediately return CSS

Test Plan

in IDE:
- open /themes/advanced/platform/inc/styles.css file for editing
- add background-color: red !important; to the end of 1st declaration (the html, body) in that file and save changes
in Admin Console
- go to Website & Content → Browse Website section
- click on Content Mode button in top frame
- click on orange Edit Content button to edit a content block
- confirm, that CKEditor background (that opened in new window) is red
- close CKEditor popup/modal window
- go to Website & Content → Structure & Data section
- open any category for editing
- click on document icon below Description field name
- confirm, that CKEditor background (that opened in new window) is red
- close CKEditor popup/modal window

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 603.Oct 21 2016, 8:35 AM

alex retitled this revision from to INP-1587 - Change stylesheet URL for CKEditor to immediately return CSS.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1587.

Herald added a reviewer: erik. · View Herald TranscriptOct 21 2016, 8:35 AM

alex edited edge metadata.Oct 21 2016, 8:55 AM

alex added a project: Restricted Project.

erik accepted this revision.Oct 24 2016, 4:14 AM

erik edited edge metadata.

This revision is now accepted and ready to land.Oct 24 2016, 4:14 AM

Closed by commit rINP16475: Fixes INP-1587 - Change stylesheet URL for CKEditor to immediately return CSS (authored by alex). · Explain WhyNov 24 2016, 3:06 PM

This revision was automatically updated to reflect the committed changes.

alex mentioned this in D338: INP-1739 - Cache results of "\fckFCKHelper::getStyles" method.Apr 18 2018, 6:12 AM

alex added a child revision: D338: INP-1739 - Cache results of "\fckFCKHelper::getStyles" method.Apr 18 2018, 6:12 AM

alex added a child revision: D278: INP-1653 - Emulate "CURLINFO_REDIRECT_URL" option in "kCurlHelper" class.Aug 5 2022, 7:02 AM

alex mentioned this in D278: INP-1653 - Emulate "CURLINFO_REDIRECT_URL" option in "kCurlHelper" class.

Revision Contents
Changeset List

Diff 641

branches/5.2.x/core/units/fck/fck_eh.php

Loading...

branches/5.2.x/core/units/helpers/fck_helper.php

Loading...