Page MenuHomeIn-Portal Phabricator

INP-1640 - Use "current" function only on arrays in "kDBConnectionDebug::GetIterator" method
ClosedPublic

Authored by alex on Nov 18 2016, 4:20 PM.

Details

Test Plan

Part 1

  1. in IDE
    • copy /index.php into /test.php
    • in the /test.php replace
$application->Run();
$application->Done();

with

$sql = 'SELECT PhraseKey
FROM ' . TABLE_PREFIX . 'LanguageLabels
LIMIT 0,1';
$data = $application->Conn->GetColIterator($sql);
  1. on Front-End
    • open Debugger
    • confirm, that above executed SQL is shown in Debugger
    • confirm, that [Result: ...] part is present below that SQL (the ... can be any phrase key)

Part 2

  1. in IDE
    • copy /index.php into /test.php
    • in the /test.php replace
$application->Run();
$application->Done();

with

$sql = 'SELECT PhraseKey
FROM ' . TABLE_PREFIX . 'LanguageLabels
LIMIT 0,1';
$data = $application->Conn->GetIterator($sql);
  1. on Front-End
    • open Debugger
    • confirm, that above executed SQL is shown in Debugger
    • confirm, that [Result: ...] part is present below that SQL (the ... can be any phrase key)

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 618.Nov 18 2016, 4:20 PM
alex retitled this revision from to INP-1640 - Use "current" function only on arrays in "kDBConnectionDebug::GetIterator" method.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1640.
alex edited the test plan for this revision. (Show Details)Nov 18 2016, 4:21 PM
alex edited edge metadata.
erik accepted this revision.Nov 22 2016, 5:35 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Nov 22 2016, 5:35 AM
This revision was automatically updated to reflect the committed changes.