Differential D303

INP-1699 - Don't cache language/theme while in temp mode
ClosedPublic
Actions

Authored by alex on May 1 2017, 7:17 AM.

Details

Reviewers

erik

Commits

rINP16583: Fixes INP-1699 - Don't cache language/theme while in temp mode

Test Plan

login to Admin Console
go to Configuration → Website → Regional section
open any language for editing
specify new $body in the HTML Version field
click on General tab to save changes into temporary table
confirm, that value of HTML Version is new $body
close editing window
go to Configuration → Website → Themes section
open any theme for editing
specify 3601 as Language Cache Timeout field value
click on General tab to save changes into temporary table
confirm, that value of Language Cache Timeout field is 3601
close editing window

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Not changing to avoid merge conflicts later.

Severity	Location	Code	Message
Error	core/units/languages/languages_item.php:306	PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace	CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace

Unit

No Unit Test Coverage

Build Status

Buildable 724
Build 724: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 738.May 1 2017, 7:17 AM

alex retitled this revision from to INP-1699 - Don't cache language/theme while in temp mode.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1699.

Herald added a reviewer: erik. · View Herald TranscriptMay 1 2017, 7:17 AM

alex mentioned this in D301: INP-1697 - Automate usage of "allow_html" block parameter.May 1 2017, 1:25 PM

erik accepted this revision.May 2 2017, 5:15 AM

erik edited edge metadata.

This revision is now accepted and ready to land.May 2 2017, 5:15 AM

Closed by commit rINP16583: Fixes INP-1699 - Don't cache language/theme while in temp mode (authored by alex). · Explain WhyJul 18 2017, 6:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	738	16543		May 1 2017, 7:17 AM	★	★
Diff 2	790	16577	rINP16583	Jul 18 2017, 6:34 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 738

View Options

core/units/languages/languages_item.php