Page MenuHomeIn-Portal Phabricator
  • Changed Files
  • branches/5.2.x/core/kernel/session/session.php

INP-1704 - Use strict comparison in "Session::NeedQueryString" method
ClosedPublic

Authored by alex on May 17 2017, 5:06 AM.

Details

Test Plan
  • on Front-End:
    1. confirm, that none of the link urls (check few urls in random places) have ?sid=... in them
  • in IDE:
    1. open /index.php for editing
    2. add $application->Session->CachedNeedQueryString = true; line after $application->Init(); line
    3. save changes
  • on Front-End:
    1. confirm, that all of the link urls (check few urls in random places) have ?sid=... in them
  • in IDE:
    1. open /index.php for editing
    2. replace $application->Session->CachedNeedQueryString = true; line with $application->Session->CachedNeedQueryString = false;
    3. save changes
  • on Front-End:
    1. confirm, that none of the link urls (check few urls in random places) have ?sid=... in them

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 744.May 17 2017, 5:06 AM
alex retitled this revision from to INP-1704 - Use strict comparison in "Session::NeedQueryString" method.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1704.
alex edited edge metadata.May 17 2017, 5:43 AM
alex added a project: Restricted Project.
erik accepted this revision.May 17 2017, 5:57 AM
erik edited edge metadata.
This revision is now accepted and ready to land.May 17 2017, 5:57 AM
This revision was automatically updated to reflect the committed changes.