Page MenuHomeIn-Portal Phabricator

INP-1709 - Validate "Categories.FriendlyURL" field for uniqueness
ClosedPublic

Authored by alex on Jun 19 2017, 11:03 AM.

Details

Test Plan
  1. login to Admin Console
  2. go to Website & ContentStructure & Data section
  3. open any category for editing
  4. put "sample" value in "Short URL" field and save changes
  5. confirm, that no validation error happened
  6. open any other category for editing
  7. put "sample" value in "Short URL" field and save changes
  8. confirm, that saving failed due validation error on "Short URL" field
  9. put platform/topics value (this is url to another category) into "Short URL" field and save changes
  10. confirm, that saving failed due validation error on "Short URL" field

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Array formatting of unit configs would be fixed in 5.3.x
SeverityLocationCodeMessage
Errorcore/units/categories/categories_config.php:393PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/categories/categories_config.php:393PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/categories/categories_config.php:394PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/categories/categories_config.php:394PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/categories/categories_config.php:400PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/categories/categories_config.php:400PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 737
Build 737: arc lint + arc unit

Event Timeline

alex created this revision.Jun 19 2017, 11:03 AM
erik accepted this revision.Jun 21 2017, 9:54 AM
This revision is now accepted and ready to land.Jun 21 2017, 9:54 AM
This revision was automatically updated to reflect the committed changes.