Page MenuHomeIn-Portal Phabricator

INP-1728 - Add dynamic LEFT JOINs using ENTER in "OnAfterConfigRead" events
ClosedPublic

Authored by erik on Oct 25 2017, 5:20 AM.

Details

Summary

Added line breaks to join expressions.

Test Plan

Add code:

$grids = $this->Application->getUnitOption($event->Prefix, 'Grids');
$grids['ReviewsSection']['Fields']['CatalogItemName'] = array('filter_block' => 'grid_like_filter');
$this->Application->setUnitOption($event->Prefix, 'Grids', $grids);

to ReviewsEventHandler::OnAfterConfigRead, after this line:

$this->Application->setUnitOption($event->Prefix, 'CalculatedFields', $calculated_fields);
  1. go to Website & ContentComments
  2. filter grid by just added CatalogItemName column
  3. confirm, that no SQL error happened

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

erik created this revision.Oct 25 2017, 5:20 AM
erik edited the test plan for this revision. (Show Details)Oct 25 2017, 5:22 AM
alex retitled this revision from INP-1728 Add dynamic LEFT JOINs using ENTER in "OnAfterConfigRead" events to INP-1728 - Add dynamic LEFT JOINs using ENTER in "OnAfterConfigRead" events.Jul 22 2022, 7:24 AM
alex updated this revision to Diff 1071.Jul 22 2022, 7:26 AM

Format changed SQLs differently

alex accepted this revision.Jul 22 2022, 7:26 AM
This revision is now accepted and ready to land.Jul 22 2022, 7:26 AM
This revision was automatically updated to reflect the committed changes.