Page MenuHomeIn-Portal Phabricator

INP-1731 - Add support for "_" in option keys in grid filters and editing controls
ClosedPublic

Authored by alex on Dec 16 2017, 1:13 PM.

Details

Test Plan

Preparations

  • in IDE:
    1. open /core/units/scheduled_tasks/scheduled_tasks_config.php file for editing
    2. locate SiteDomainLimitation field declaration
    3. change option_key_field field value from DomainId to CONCAT("TEST_", DomainId)
    4. save changes

Test plan

  1. login to Admin Console
  2. go to ConfigurationWebsiteSite Domains section
  3. create 3 site domains
  4. go to ConfigurationWebsiteScheduled Tasks section
  5. open any record for editing
  6. check 1st and 3rd site domains in the Site Domain Limitation field
  7. save changes
  8. confirm, that in grid edited record has 1st and 3rd site domain selected in the Site Domain Limitation field
  9. reset grid filters (if any applied) by pressing Reset button on the toolbar
  10. in the Site Domain Limitation column filter select 3rd site domain and apply search filter
  11. confirm, that only edited before record is shown in grid
  12. click Open Filter in Site Domain Limitation column filter
  13. confirm, that 3rd site domain is selected in filter

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 825
Build 825: arc lint + arc unit

Event Timeline

alex created this revision.Dec 16 2017, 1:13 PM
erik accepted this revision.Feb 8 2018, 5:40 AM
This revision is now accepted and ready to land.Feb 8 2018, 5:40 AM
This revision was automatically updated to reflect the committed changes.