Page MenuHomeIn-Portal Phabricator
  • Changed Files
  • branches/5.2.x/core/kernel/utility/logger.php

INP-1764 - Set correct exit code, when exception happens in CLI
ClosedPublic

Authored by alex on Apr 26 2019, 3:03 AM.

Details

Test Plan
  1. open SSH connection to Web Server with In-Portal on it
  2. change current directory to In-Portal directory
  3. run php index.php ; echo $? command
  4. confirm, that after all output 0 is displayed (means no errors)
  5. in the /index.php file after $application->Init(); line add throw new RuntimeException('Test');
  6. run php index.php ; echo $? command
  7. confirm, that after all output 1 is displayed (means has errors)

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Apr 26 2019, 3:03 AM
alex requested review of this revision.Apr 26 2019, 3:03 AM
alex added a project: Restricted Project.Apr 26 2019, 3:04 AM
erik requested changes to this revision.Apr 26 2019, 7:17 AM

Tested, in both cases got wrong code 255 (not 0 and not 1 )

This revision now requires changes to proceed.Apr 26 2019, 7:17 AM
erik accepted this revision.Apr 14 2020, 5:45 AM

Tested - got 0 and 1 codes, as planned.

This revision is now accepted and ready to land.Apr 14 2020, 5:45 AM
erik added a comment.Apr 14 2020, 2:03 PM
This comment was removed by erik.
This revision was landed with ongoing or failed builds.Jan 5 2021, 2:52 AM
This revision was automatically updated to reflect the committed changes.