optimized default persistent settings usage
Details
Details
- Set DBG_REDIRECT debugger setting to 1
- Login as root to the adm.console
- Go to Catalog & Website → Labels & Phrases section
- Truncate UserPersistentSessionData table
- Change grid sorting to "Modified On"
- Confirm, that in debugger shown only 3 select-SQL from UserPersistentSessionData table
- Change grid sorting to "Phrase"
- Confirm, that in debugger shown only 3 select-SQL from UserPersistentSessionData table
- Login as non-root to the adm.console
- Go to Catalog & Website → Labels & Phrases section
- Confirm, that Grid is sorted by "Phrase" column (same as was with root user)
- Change grid sorting to "Modified On"
- Confirm, that in debugger shown only 3 select-SQL from UserPersistentSessionData table
Diff Detail
Diff Detail
- Repository
- rINP In-Portal
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Also since task does optimization only, then here we should be checking that persistent setting retrieval with/without fallback code works as before (not covered) + verify performed SQL count (covered).
| core/kernel/session/session_storage.php | ||
|---|---|---|
| 365 ↗ | (On Diff #907) | according to implementation plan here you should be loading persistent settings of $default_user_id user |
| core/kernel/session/session_storage.php | ||
|---|---|---|
| 380 ↗ | (On Diff #908) | please remove (array) The kDBConnection::GetCol method only returns array (when no results found the array is empty). |