Page MenuHomeIn-Portal Phabricator

INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used)
ClosedPublic

Authored by alex on Jul 10 2019, 10:18 AM.

Details

Test Plan

Preparations

  • apply patch from D368

Testing

  • test using Image field of poll unit
  • set storage_format option of above field to resize:100x100;output_format:jpg
  • when you need to test image format change upload png instead of jpg image
  • when you need to test storage engine in work set storage_engine field option to StorageEngine::HASH

Test these cases in every possible combination (8 in total):

  1. case by uploader type:
    • HTML4 uploader ("inp_edit_upload" block)
    • HTML5 uploader ("inp_edit_swf_upload" block)
  2. case by file extension change upon resize via "storage_format" option:
    • file extension changed
    • file extension not changed
  3. case by storage engine:
    • storage engine used
    • storage engine not used

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 941
Build 941: arc lint + arc unit

Event Timeline

alex created this revision.Jul 10 2019, 10:18 AM
alex requested review of this revision.Jul 10 2019, 10:18 AM
alex edited the test plan for this revision. (Show Details)Jul 10 2019, 10:30 AM
alex edited the test plan for this revision. (Show Details)Jul 10 2019, 11:43 PM
erik accepted this revision.Jul 12 2019, 5:38 AM
This revision is now accepted and ready to land.Jul 12 2019, 5:38 AM
alex updated this revision to Diff 920.Jul 15 2019, 8:12 AM

Usage of \FileHelper::ensureUniqueFilename was expecting specific version of that method only available in In-Portal 5.2.x.

alex updated this revision to Diff 921.Jul 15 2019, 8:13 AM

Debug code removed.

This revision was automatically updated to reflect the committed changes.