Page MenuHomeIn-Portal Phabricator

INP-1796 - Add method for setting database error handler
ClosedPublic

Authored by alex on Dec 31 2020, 6:13 AM.

Details

Test Plan
NOTE: Use your table prefix instead of 52x_ during testing.
  1. execute UPDATE 52x_Modules` SET AppliedDBRevisions = NULL;` sql to mark all db revisions as non-executed
  2. change contents of /modules/custom/install/project_upgrades.sql file to this:
# r1: Initial Project Task (#TASK_ID)
UPDATE NonExistingTable;

# r2: Initial Project Task (#TASK_ID)
SELECT UNIX_TIMESTAMP();
  1. login to Admin Console
  2. go to ToolsSystem Tools section
  3. press "Deploy" button
  4. confirm, that upon attempt execute SQLs from r1 the result was shown as FAILED (in red color) instead of OK (in green color) and script execution was stopped

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Not fixing code, that wasn't added in this task.
SeverityLocationCodeMessage
Errorcore/kernel/db/db_connection.php:925PHPCS.E.CodingStandard.Classes.ClassDeclaration.NewlinesAfterCloseBraceCodingStandard.Classes.ClassDeclaration.NewlinesAfterCloseBrace
Errorcore/kernel/db/db_connection.php:925PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBraceCodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace
Errorcore/kernel/db/i_db_connection.php:272PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBraceCodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace
Unit
No Unit Test Coverage
Build Status
Buildable 983
Build 983: arc lint + arc unit

Event Timeline

alex created this revision.Dec 31 2020, 6:13 AM
alex requested review of this revision.Dec 31 2020, 6:13 AM
erik accepted this revision.Feb 19 2021, 3:22 AM
This revision is now accepted and ready to land.Feb 19 2021, 3:22 AM
This revision was landed with ongoing or failed builds.Jul 8 2022, 9:36 AM
This revision was automatically updated to reflect the committed changes.