Page MenuHomeIn-Portal Phabricator

MINC-199 - Escape MySQL 5.7 keywords in the "modules/in-commerce/install/install_schema.sql" file
ClosedPublic

Authored by alex on Mar 23 2021, 3:54 AM.

Details

Test Plan
NOTE: Testing must be performed on MySQL 5.7+. On MariaDB, the VIRTUAL isn't even a reserved keyword (see https://mariadb.com/kb/en/reserved-words/).
  1. perform installation of In-Portal with all modules
  2. confirm, that there are no SQL errors that are blocking the installation process

Diff Detail

Repository
rMINC Modules.In-Commerce
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Mar 23 2021, 3:54 AM
alex requested review of this revision.Mar 23 2021, 3:54 AM
alex added a project: Restricted Project.Mar 23 2021, 3:54 AM
alex edited the test plan for this revision. (Show Details)Mar 24 2021, 5:40 AM
alex edited the test plan for this revision. (Show Details)Mar 24 2021, 5:46 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2022, 8:53 AM
This revision was automatically updated to reflect the committed changes.