Page MenuHomeIn-Portal Phabricator

INP-1802 - Speed up detection of countries with states
ClosedPublic

Authored by alex on Apr 22 2021, 8:38 AM.

Details

Test Plan
  1. login to Admin Console
  2. go to E-commerceOrders section
  3. press Add toolbar button on the Incomplete tab
  4. go to Shipping tab in the order adding window, that appeared
  5. press on the Shipping tab again
  6. confirm, that:
    1. validaton error for missing Shipping State field happened
    2. in the Debugger there is an SQL query for selecting countries with states (search for country_states_helper.php:63 text)
  7. press on the Shipping tab again
  8. confirm, that:
    1. validaton error for missing Shipping State field happened
    2. in the Debugger there isn't an SQL query for selecting countries with states (search for country_states_helper.php:63 text)
  9. close order adding window by pressing Cancel
  10. go to ConfigurationWebsiteCountries & States section
  11. try deleting record except United States or Canada
  12. repeat above steps with Shipping tab to confirm, that SQL appears once again and then never is invoked

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1040
Build 1040: arc lint + arc unit

Event Timeline

alex created this revision.Apr 22 2021, 8:38 AM
alex requested review of this revision.Apr 22 2021, 8:38 AM
alex added a project: Restricted Project.Apr 22 2021, 8:38 AM
erik accepted this revision.May 7 2021, 2:44 AM
This revision is now accepted and ready to land.May 7 2021, 2:44 AM
This revision was automatically updated to reflect the committed changes.