Page MenuHomeIn-Portal Phabricator

INP-1814 - Use relative paths in error messages
ClosedPublic

Authored by alex on May 20 2022, 4:20 AM.

Details

Test Plan
  1. in the Admin Console
    1. login to the Admin Console
    2. go to Website & ContentLabels & Phrases section
    3. confirm, that correct grid was shown
  2. in the IDE
    1. open /system/debug.php file for editing
    2. disable debug mode by commenting out DBEUG_MODE key in the $dbg_options array
    3. save changes
    4. open file /core/kernel/application.php for editing
    5. in the \kApplication::Init method add throw new RuntimeException('sample exception'); before the return true; statement at the end
    6. save changes
    7. open /tools/run_event.php file for editing
    8. comment-out the exit_code(1, 'This script needs to be enabled manually !'); line
    9. save changes
  3. in the Admin Console
    1. go to Website & ContentLabels & Phrases section
    2. confirm, that error message being shown doesn't include absolute file path
  4. in the CLI
    1. run the php tools/run_event.php test:test b674006f3edb1d9cd4d838c150b0567d script in project root folder
    2. confirm, that error message/trace being shown doesn't include absolute file path

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Not related to performed changes.
SeverityLocationCodeMessage
Errorcore/kernel/utility/logger.php:1006PHPCS.E.CodingStandard.Commenting.FunctionComment.MissingParamTagCodingStandard.Commenting.FunctionComment.MissingParamTag
Unit
No Unit Test Coverage
Build Status
Buildable 1065
Build 1065: arc lint + arc unit

Event Timeline

alex created this revision.May 20 2022, 4:20 AM
alex requested review of this revision.May 20 2022, 4:20 AM
alex added a project: Restricted Project.May 20 2022, 4:21 AM
alex edited the test plan for this revision. (Show Details)May 20 2022, 5:07 AM
erik accepted this revision.Jul 14 2022, 9:49 AM
This revision is now accepted and ready to land.Jul 14 2022, 9:49 AM
This revision was landed with ongoing or failed builds.Jul 19 2022, 6:04 AM
This revision was automatically updated to reflect the committed changes.