Page MenuHomeIn-Portal Phabricator

INP-1815 - Anonymize error message content for Regular Website Visitors
ClosedPublic

Authored by alex on May 20 2022, 5:34 AM.

Details

Test Plan
  1. in the Admin Console
    1. login to the Admin Console
    2. go to Website & ContentLabels & Phrases section
    3. confirm, that correct grid was shown
  2. in the IDE
    1. open /system/debug.php file for editing
    2. disable debug mode by commenting out DBEUG_MODE key in the $dbg_options array
    3. save changes
    4. open file /core/kernel/application.php for editing
    5. in the \kApplication::Init method add throw new RuntimeException('sample exception'); before the return true; statement at the end
    6. save changes
  3. in the Admin Console
    1. go to Website & ContentLabels & Phrases section
    2. confirm, that web server details aren't exposed in the error message and it's theme is different now
    3. remember used "Reference" value (the number before -)
  4. in the IDE
    1. open file /core/kernel/application.php for editing
    2. rollback changes made to the \kApplication::Init method
    3. save changes
  5. in the Admin Console
    1. go to Logs & ReportsSystem Log section
    2. confirm, that:
      1. a system log record with a previously recorded reference can be found in Unique ID column
      2. a Unique ID field with that reference is also shown in the system log record detail template

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.May 20 2022, 5:34 AM
alex requested review of this revision.May 20 2022, 5:34 AM
alex edited the test plan for this revision. (Show Details)May 20 2022, 5:56 AM
alex added a project: Restricted Project.
alex updated this revision to Diff 1037.May 20 2022, 5:59 AM

Show the Unique ID column in the Logs & Reports > System Logs section.

erik accepted this revision.Jul 14 2022, 9:39 AM
This revision is now accepted and ready to land.Jul 14 2022, 9:39 AM
This revision was landed with ongoing or failed builds.Jul 19 2022, 6:08 AM
This revision was automatically updated to reflect the committed changes.