Page MenuHomeIn-Portal Phabricator

INP-1818 - Reset cURL settings only upon connection closing
ClosedPublic

Authored by alex on Aug 5 2022, 6:28 AM.

Details

Test Plan
  • in IDE:
    • open /index.php file for editing
    • replace $application->Run(); line with the following code:
/** @var kCurlHelper $curl_helper */
$curl_helper = $application->recallObject('CurlHelper');

$curl_helper->followLocation = false;
$curl_helper->Send('http://www.google.com', false);
echo 'Follow Location Enabled: ' . ($curl_helper->followLocation ? 'Y' : 'N') . '<br/>';
$curl_helper->CloseConnection();

$curl_helper->followLocation = true;
$curl_helper->Send('http://www.google.com', false);
echo 'Follow Location Enabled: ' . ($curl_helper->followLocation ? 'Y' : 'N') . '<br/>';
$curl_helper->CloseConnection();
    • save changes
  • in Web Browser:
    • open /index.php
    • confirm, that page output contains this text:
Follow Location Enabled: N
Follow Location Enabled: Y

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Aug 5 2022, 6:28 AM
alex requested review of this revision.Aug 5 2022, 6:28 AM
alex edited the test plan for this revision. (Show Details)Aug 5 2022, 6:30 AM
alex edited the test plan for this revision. (Show Details)
erik accepted this revision.Aug 9 2022, 5:53 AM
This revision is now accepted and ready to land.Aug 9 2022, 5:53 AM
This revision was landed with ongoing or failed builds.Wed, Nov 9, 9:56 AM
This revision was automatically updated to reflect the committed changes.