Differential D428

INP-1824 - Don't parse Cookies in CLI mode
ClosedPublic
Actions

Authored by alex on Sep 8 2022, 7:53 AM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rINP16729: Fixes INP-1824 - Don't parse Cookies in CLI mode

Test Plan

open /tools/run_event.php script for editing
comment-out the exit_code(1, 'This script needs to be enabled manually !'); line (if not already commented-out)
as the 1st line in the script (after licensing comment) add $_COOKIE['fake_var'] = 'fake_value';
after $application->Init(); add die('is_fake_var_parsed: ' . ($application->GetVarDirect('fake_var', 'Cookie') === 'fake_value' ? 'Y' : 'N') . PHP_EOL);
save changes
run the php tools/run_event.php test:test b674006f3edb1d9cd4d838c150b0567d command from the root folder of In-Portal installation
confirm, that output contains: is_fake_var_parsed: N

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Sep 8 2022, 7:53 AM

Herald added a reviewer: erik. · View Herald TranscriptSep 8 2022, 7:53 AM

alex requested review of this revision.Sep 8 2022, 7:53 AM

Harbormaster completed remote builds in B1126: Diff 1091.Sep 8 2022, 7:53 AM

alex edited the test plan for this revision. (Show Details)Sep 8 2022, 8:24 AM

alex mentioned this in D430: INP-1822 - Use modern cookie encryption library.Sep 8 2022, 9:58 AM

alex added a child revision: D430: INP-1822 - Use modern cookie encryption library.

erik accepted this revision.Sep 9 2022, 9:41 AM

This revision is now accepted and ready to land.Sep 9 2022, 9:41 AM

This revision was landed with ongoing or failed builds.Sep 13 2022, 7:33 AM

Closed by commit rINP16729: Fixes INP-1824 - Don't parse Cookies in CLI mode (authored by alex, committed by ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1095

branches/5.2.x/core/kernel/utility/http_query.php

Loading...