Page MenuHomeIn-Portal Phabricator

INP-1824 - Don't parse Cookies in CLI mode
ClosedPublic

Authored by alex on Thu, Sep 8, 7:53 AM.

Details

Test Plan
  1. open /tools/run_event.php script for editing
  2. comment-out the exit_code(1, 'This script needs to be enabled manually !'); line (if not already commented-out)
  3. as the 1st line in the script (after licensing comment) add $_COOKIE['fake_var'] = 'fake_value';
  4. after $application->Init(); add die('is_fake_var_parsed: ' . ($application->GetVarDirect('fake_var', 'Cookie') === 'fake_value' ? 'Y' : 'N') . PHP_EOL);
  5. save changes
  6. run the php tools/run_event.php test:test b674006f3edb1d9cd4d838c150b0567d command from the root folder of In-Portal installation
  7. confirm, that output contains: is_fake_var_parsed: N

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Thu, Sep 8, 7:53 AM
alex requested review of this revision.Thu, Sep 8, 7:53 AM
alex edited the test plan for this revision. (Show Details)Thu, Sep 8, 8:24 AM
erik accepted this revision.Fri, Sep 9, 9:41 AM
This revision is now accepted and ready to land.Fri, Sep 9, 9:41 AM
This revision was landed with ongoing or failed builds.Tue, Sep 13, 7:33 AM
Closed by commit rINP16729: Fixes INP-1824 - Don't parse Cookies in CLI mode (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.