Differential D441

INP-1836 - Don't serialize "SecurityEncrypter" class properties
ClosedPublic
Actions

Authored by alex on Feb 7 2023, 3:05 AM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rINP16771: Fixes fINP-1836 - Don't serialize "SecurityEncrypter" class properties

Test Plan

in IDE:
1. open /index.php for editing
2. replace $application->Run(); line with echo serialize($application->recallObject('SecurityEncrypter'));
3. save changes
in Web Browser:
1. open the /index.php file (the Front-End)
2. confirm, that encryptionKey property isn't shown as a serialization result

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Feb 7 2023, 3:05 AM

Herald added a reviewer: erik. · View Herald TranscriptFeb 7 2023, 3:05 AM

alex requested review of this revision.Feb 7 2023, 3:05 AM

Harbormaster completed remote builds in B1172: Diff 1133.Feb 7 2023, 3:05 AM

erik accepted this revision.Feb 7 2023, 6:49 AM

This revision is now accepted and ready to land.Feb 7 2023, 6:49 AM

Closed by commit rINP16771: Fixes fINP-1836 - Don't serialize "SecurityEncrypter" class properties (authored by alex, committed by ). · Explain WhyTue, Nov 21, 3:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1171

branches/5.2.x/core/kernel/security/SecurityEncrypter.php

Loading...