Differential D3 Diff 8 core/install/upgrades.sql

Changeset View

Standalone View

core/install/upgrades.sql

Context not available.
	UPDATE LanguageLabels	UPDATE LanguageLabels
	SET l1_Translation = 'Field value length is out of range, possible value length from {min_length} to {max_length}'	SET l1_Translation = 'Field value length is out of range, possible value length from {min_length} to {max_length}'
	WHERE PhraseKey = 'LA_ERR_LENGTH_OUT_OF_RANGE';	WHERE PhraseKey = 'LA_ERR_LENGTH_OUT_OF_RANGE';

		UPDATE SystemSettings
		SET VariableName = 'NotFoundErrorTemplate'
		WHERE VariableName = 'ErrorTemplate';

		INSERT INTO SystemSettings (VariableId, VariableName, VariableValue, ModuleOwner, Section, Heading, Prompt, ElementType, Validation, ValueList, DisplayOrder, GroupDisplayOrder, Install, HintLabel)
		VALUES (DEFAULT, 'FatalErrorTemplate', 'error_fatal', 'In-Portal', 'in-portal:configure_advanced', 'la_section_SettingsWebsite', 'la_config_error_template', 'text', '', '', 10.04, 0, 0, null);
Context not available.
		alexUnsubmitted Not Done Reply Several more issues with this: If a variable is renamed in `upgrades.sql` then it have no effect on clean In-Portal installation. To make clean installation work it needs to be renamed in `INSERT INTO` sql in the `install_data.sql` file as well. You have renamed variable only, but not it's usages. I've counted 2 usages at least in the Core module. alex: Several more issues with this: # If a variable is renamed in `upgrades.sql` then it have no…
		alexUnsubmitted Not Done Reply The `DisplayOrder` column value (the `10.04` in above SQL) should be unique across same configuration group. Right now it exactly matches value of `NoPermissionTemplate` system setting. You need to: shift down all configuration variables in same sub-section use `10.05` as `DisplayOrder` column value for that new system setting update `install_data.sql` to reflect new value in `DisplayOrder` column I usually use SQL similar to this to shift up/down system settings in particular sub-group: UPDATE SystemSettings SET DisplayOrder = ROUND(DisplayOrder + 0.01, 2) WHERE Section = 'x' and Heading = 'y' AND DisplayOrder > z alex: The `DisplayOrder` column value (the `10.04` in above SQL) should be unique across same…
		alexUnsubmitted Not Done Reply Just noticed that used label doesn't match system setting name and should be `la_config_ FatalErrorTemplate`. You can see on screenshot above that two system settings have identical translation. alex: Just noticed that used label doesn't match system setting name and should be `la_config_…