Changeset View
Standalone View
core/admin_templates/incs/footer.tpl
| Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Line(s) | |||||
| <inp2:adm_AfterScript/> | <inp2:adm_AfterScript/> | ||||
| <inp2:m_ifnot check="m_Param" name="noform" equals_to="yes"> | <inp2:m_ifnot check="m_Param" name="noform" equals_to="yes"> | ||||
| <inp2:m_RenderElement name="kernel_form_end"/> | <inp2:m_RenderElement name="kernel_form_end"/> | ||||
| </inp2:m_ifnot> | </inp2:m_ifnot> | ||||
| <div id="nlsMenuPlace"></div> | <div id="nlsMenuPlace"></div> | ||||
| </body> | </body> | ||||
| </html> | </html> | ||||
| No newline at end of file | |||||
| <inp2:m_if check="m_Get" name="edit_field"> | |||||
| <script type="text/javascript"> | |||||
| var $row = get_control('<inp2:adm_PassedPrefixTag tag="InputName" name="#FIELD_NAME#" js_escape="1"/>', '<inp2:m_Get name="edit_field"/>', 'row'); | |||||
alex: Please replace with:
```
lang=js
var $row = get_control('<inp2:$prefix_InputName… | |||||
Not Done ReplyDecided not to do this. alex: Decided not to do this. | |||||
| if ( $row ) { | |||||
alexUnsubmitted Not Done ReplyElement query code & IF statement needs to be placed inside hook code. The m:OnAfterFormInit hook is called after Form class wraps elements in <div id="scroll_container"> DIV in another DIV used for scrolling. Nature of wrapping operation is performing copy/paste of elements in that DIV and reference to DOM element stored in $row variable would point to different element at that point. alex: Element query code & IF statement needs to be placed inside hook code.
---
The `m… | |||||
Not Done ReplyIt appears, that this change wasn't done in 377 diff. alex: It appears, that this change wasn't done in 377 diff. | |||||
Not Done ReplyPlease also add js_escape="1" to the m_Get tag call. alex: Please also add `js_escape="1"` to the `m_Get` tag call. | |||||
| <inp2:m_if check="adm_UsePopups"> | |||||
| Application.setHook('m:OnAfterFormInit', function () { | |||||
| $('#scroll_container_container').scrollTop($($row).offset().top - $('#scroll_container_container').offset().top); | |||||
| }); | |||||
| <inp2:m_else/> | |||||
| $(document).ready(function () { | |||||
Not Done ReplyPlease also add js_escape="1" to the m_Get tag call. alex: Please also add `js_escape="1"` to the `m_Get` tag call. | |||||
| parent.frames['main'].scrollBy(0, $($row).offset().top); | |||||
alexUnsubmitted Not Done Reply
alex: # replace `parent.frames['main']` with `getFrame('main')`
# use same `scrollTop` method, but… | |||||
erikAuthorUnsubmitted Not Done ReplyscrollTop on the document object not always working - this solution is not cross-browser. erik: scrollTop on the document object not always working - this solution is not cross-browser. | |||||
alexUnsubmitted Not Done ReplyCan you please be more specific about browsers, where this doesn't work? On both Chrome and Firefox I did this:
window.frames['main'].$(window.frames['main'].document).scrollTop(10);
alex: Can you please be more specific about browsers, where this doesn't work?
---
On both Chrome… | |||||
erikAuthorUnsubmitted Not Done ReplyYes, it works. Seems, i used some wrong approach when trying scrollTop. I do not remember what code was tried before scrollBy solution. erik: Yes, it works. Seems, i used some wrong approach when trying scrollTop. I do not remember what… | |||||
Not Done ReplyIt appears, that this change wasn't done in 377 diff. alex: It appears, that this change wasn't done in 377 diff. | |||||
| }); | |||||
| </inp2:m_if> | |||||
| } | |||||
| </script> | |||||
| </inp2:m_if> | |||||
alexUnsubmitted Not Done ReplyMove all this code at the end of form_error_warning block definition. The prefix block parameter available in form_error_warning block would allow to universally identify edited unit. alex: Move all this code at the end of `form_error_warning` block definition.
---
The `prefix`… | |||||
Not Done ReplyAfter discussing over Skype decided not to do this, because the form_error_warning block is only shown when there is an error on the form. alex: After discussing over Skype decided not to do this, because the `form_error_warning` block is… | |||||
Not Done ReplyPlease move JavaScript code block up in the DOM tree to be last node inside <body> tag. Having JavaScript code after </html> tag isn't guaranteed to work in all Web Browsers. alex: Please move JavaScript code block up in the DOM tree to be last node inside `<body>` tag. | |||||
Please replace with:
See comment related to PassedPrefixTag declaration.