Differential D124 Diff 377 core/units/admin/admin_tag_processor.php

Changeset View

Standalone View

core/units/admin/admin_tag_processor.php

	Show First 20 Lines • Show All 1213 Lines • ▼ Show 20 Line(s)

	$block_params = $this->prepareTagParams($params);			$block_params = $this->prepareTagParams($params);
	$block_params['name'] = $params['render_as'];			$block_params['name'] = $params['render_as'];
	$block_params['resource_extension'] = $extension;			$block_params['resource_extension'] = $extension;
	$block_params['resource_file'] = $name . '/' . $filename;			$block_params['resource_file'] = $name . '/' . $filename;

	return $this->Application->ParseBlock($block_params);			return $this->Application->ParseBlock($block_params);
	}			}

				/**
				* Processes tag of passed prefix
				*
				* @param array $params Tag params.
				*
				* @return string
				*/
				protected function PassedPrefixTag(array $params)
				{
				$prefix = explode(',', $this->Application->GetVar('passed'));
				$prefix = array_pop($prefix);
				alexUnsubmitted Not Done Reply please change to: $passed_prefixes = explode(',', $this->Application->GetVar('passed')); $last_prefix = array_pop($passed_prefixes); use `$last_prefix` variable below instead of `$prefix` alex: 1. please change to: ``` lang=php $passed_prefixes = explode(',', $this->Application->GetVar…

				return $this->Application->ProcessParsedTag($prefix, $params['tag'], $params);
				alexUnsubmitted Not Done Reply Remove `tag` parameter from `$params` array before calling tag from `$params['tag']`. The `tag` parameter is passed to called tag, but that tag doesn't know what to do with it. alex: Remove `tag` parameter from `$params` array before calling tag from `$params['tag']`. --- The…
				}

				alexUnsubmitted Not Done Reply Please delete this. The prefix guessing logic doesn't cover the case, when there are multiple prefixes in url and one, that is used on the form isn't last passed. alex: Please delete this. --- The prefix guessing logic doesn't cover the case, when there are…
				alexUnsubmitted Not Done Reply Decided not to do this. Please update test plan to confirm, that it works for non-categories (e.g. products) as well. alex: Decided not to do this. Please update test plan to confirm, that it works for non-categories…
	}			}