Changeset View
Changeset View
Standalone View
Standalone View
core/units/admin/admin_tag_processor.php
Show First 20 Lines • Show All 1212 Lines • ▼ Show 20 Line(s) | |||||
$included[$filename] = 1; | $included[$filename] = 1; | ||||
$block_params = $this->prepareTagParams($params); | $block_params = $this->prepareTagParams($params); | ||||
$block_params['name'] = $params['render_as']; | $block_params['name'] = $params['render_as']; | ||||
$block_params['resource_extension'] = $extension; | $block_params['resource_extension'] = $extension; | ||||
$block_params['resource_file'] = $name . '/' . $filename; | $block_params['resource_file'] = $name . '/' . $filename; | ||||
return $this->Application->ParseBlock($block_params); | return $this->Application->ParseBlock($block_params); | ||||
} | } | ||||
Lint: Generic.WhiteSpace.ScopeIndent.IncorrectExact: Line indented incorrectly; expected 1 tabs, found 2 | |||||
/** | |||||
* Processes tag of passed prefix | |||||
* | |||||
* @param array $params Tag params. | |||||
* | |||||
* @return string | |||||
*/ | |||||
protected function PassedPrefixTag(array $params) | |||||
Line indented incorrectly; expected 1 tabs, found 2 Lint: Generic.WhiteSpace.ScopeIndent.IncorrectExact: Line indented incorrectly; expected 1 tabs, found 2 | |||||
{ | |||||
$passed_prefixes = explode(',', $this->Application->GetVar('passed')); | |||||
$last_prefix = array_pop($passed_prefixes); | |||||
Not Done Reply
$passed_prefixes = explode(',', $this->Application->GetVar('passed')); $last_prefix = array_pop($passed_prefixes);
alex: 1. please change to:
```
lang=php
$passed_prefixes = explode(',', $this->Application->GetVar… | |||||
$tag = $params['tag']; | |||||
unset($params['tag']); | |||||
Not Done ReplyRemove tag parameter from $params array before calling tag from $params['tag']. The tag parameter is passed to called tag, but that tag doesn't know what to do with it. alex: Remove `tag` parameter from `$params` array before calling tag from `$params['tag']`.
---
The… | |||||
return $this->Application->ProcessParsedTag($last_prefix, $tag, $params); | |||||
Not Done ReplyPlease delete this. The prefix guessing logic doesn't cover the case, when there are multiple prefixes in url and one, that is used on the form isn't last passed. alex: Please delete this.
---
The prefix guessing logic doesn't cover the case, when there are… | |||||
Not Done ReplyDecided not to do this. Please update test plan to confirm, that it works for non-categories (e.g. products) as well. alex: Decided not to do this.
Please update test plan to confirm, that it works for non-categories… | |||||
} | |||||
Line indented incorrectly; expected 1 tabs, found 2 Lint: Generic.WhiteSpace.ScopeIndent.IncorrectExact: Line indented incorrectly; expected 1 tabs, found 2 | |||||
} | } | ||||
Expected 0 spaces before closing brace; 4 found Lint: CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace: Expected 0 spaces before closing brace; 4 found | |||||
Line indented incorrectly; expected 0 tabs, found 1 Lint: Generic.WhiteSpace.ScopeIndent.IncorrectExact: Line indented incorrectly; expected 0 tabs, found 1 |
Line indented incorrectly; expected 1 tabs, found 2