Differential D399 Diff 1002 core/kernel/managers/scheduled_task_manager.php

Changeset View

Standalone View

core/kernel/managers/scheduled_task_manager.php

	Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Line(s)
	}			}

	ignore_user_abort(true);			ignore_user_abort(true);
	set_time_limit(0);			set_time_limit(0);

	$events_source = $this->getAll();			$events_source = $this->getAll();

	$user_id = $this->Application->RecallVar('user_id');			$user_id = $this->Application->RecallVar('user_id');
	$this->Application->StoreVar('user_id', USER_ROOT, true); // to prevent permission checking inside events, true for optional storage			// To prevent permission checking inside events, true for optional storage.
				$this->Application->StoreVar('user_id', USER_SYSTEM, true);
				alexUnsubmitted Done Reply Since you're at this line please do minimal CS fixing. Add tests to confirm, that this user is actually used, e.g. scheduled task that creates a record owned by a currently logged-in user should use a `system` user. alex: # Since you're at this line please do minimal CS fixing. # Add tests to confirm, that this user…

	/** @var SiteHelper $site_helper */			/** @var SiteHelper $site_helper */
	$site_helper = $this->Application->recallObject('SiteHelper');			$site_helper = $this->Application->recallObject('SiteHelper');

	$site_domain_id = $site_helper->getDomainByName('DomainName', DOMAIN);			$site_domain_id = $site_helper->getDomainByName('DomainName', DOMAIN);

	foreach ($events_source as $short_name => $event_data) {			foreach ($events_source as $short_name => $event_data) {
	// Scheduled task was updated from another process.			// Scheduled task was updated from another process.
	▲ Show 20 Lines • Show All 117 Lines • Show Last 20 Lines