Changeset View
Changeset View
Standalone View
Standalone View
core/units/helpers/brackets_helper.php
| Show First 20 Lines • Show All 352 Lines • ▼ Show 20 Line(s) | |||||
| } | } | ||||
| else { // this is when ok - add to end_values list | else { // this is when ok - add to end_values list | ||||
| $end_values[] = $record[$this->max_field]; | $end_values[] = $record[$this->max_field]; | ||||
| } | } | ||||
| } | } | ||||
| // sort brackets by 2nd column (Max values) | // sort brackets by 2nd column (Max values) | ||||
| uasort($temp, Array (&$this, 'compareBrackets')); | uasort($temp, Array (&$this, 'compareBrackets')); | ||||
| reset($temp); | reset($temp); | ||||
| $first_item = each($temp); | |||||
| $first_item_key = $first_item['key']; | |||||
alex: Delete.
---
Looking through the changes the `\PricingEventHandler::OnArrangeBrackets` method… | |||||
| $linked_info = $object->getLinkedInfo(); | $linked_info = $object->getLinkedInfo(); | ||||
| $sql = 'SELECT %s FROM %s WHERE %s = %s'; | $sql = 'SELECT %s FROM %s WHERE %s = %s'; | ||||
| $ids = $this->Conn->GetCol( sprintf($sql, $object->IDField, $object->TableName, $linked_info['ForeignKey'], $linked_info['ParentId']) ); | $ids = $this->Conn->GetCol( sprintf($sql, $object->IDField, $object->TableName, $linked_info['ForeignKey'], $linked_info['ParentId']) ); | ||||
| if ( is_array($ids) ) { | if ( is_array($ids) ) { | ||||
| usort($ids, Array (&$this, 'sortBracketIDs')); | usort($ids, Array (&$this, 'sortBracketIDs')); | ||||
| } | } | ||||
| ▲ Show 20 Lines • Show All 104 Lines • Show Last 20 Lines | |||||
Delete.
Looking through the changes the \PricingEventHandler::OnArrangeBrackets method, doing a similar thing, caught my attention. After that, it became obvious, that both variables are just a copy/paste artifact and are no longer needed.