Differential D81

MINC-127 Optimize "ord_UsingCreditCard" tag
ClosedPublic
Actions

Authored by glebs on Jun 10 2015, 10:08 AM.

Details

Reviewers

alex

Commits

rMINC16248: Fixes MINC-127 - Optimize "ord:UsingCreditCard" tag

Test Plan

Create several orders with different payment types: with CC and without
Update element grid_billinglink_td and add some usage of tag UsingCreditCard
Check any orders list for SQL queries - it should have only one select from payment types table

Diff Detail

Repository

rINP In-Portal

Branch

/w/in-portal.full/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

glebs updated this revision to Diff 213.Jun 10 2015, 10:08 AM

glebs retitled this revision from to MINC-127 Optimize "ord:UsingCreditCard" tag.

glebs updated this object.

glebs edited the test plan for this revision. (Show Details)

glebs added 1 JIRA issue(s): MINC-127.

Herald added a reviewer: alex. · View Herald TranscriptJun 10 2015, 10:08 AM

alex requested changes to this revision.Jun 10 2015, 10:17 AM

alex edited edge metadata.

alex added inline comments.

modules/in-commerce/units/orders/orders_tag_processor.php
521–524	It should be `boolean`, not `bool`.
530–531	This should be done only when needed, not all the time.
530–534	Please rename to `$payment_type`.
534	The `INNER JOIN` is equivalent to just `JOIN`.

This revision now requires changes to proceed.Jun 10 2015, 10:17 AM

Requested changes

alex requested changes to this revision.Jun 10 2015, 10:37 AM

alex edited edge metadata.

alex added inline comments.

modules/in-commerce/units/orders/orders_tag_processor.php
544–547	We can actually extract this to separate `getPrimaryPaymentType` that will have `$primary_payment_type` variable in it.

This revision now requires changes to proceed.Jun 10 2015, 10:37 AM

new getPrimaryPaymentType method

alex accepted this revision.Jun 10 2015, 11:39 AM

alex edited edge metadata.

This revision is now accepted and ready to land.Jun 10 2015, 11:39 AM

Closed by commit rMINC16248: Fixes MINC-127 - Optimize "ord:UsingCreditCard" tag (authored by alex). · Explain WhySep 2 2015, 3:55 PM

This revision was automatically updated to reflect the committed changes.

alex edited edge metadata.Mar 10 2016, 6:11 AM

alex added a project: Restricted Project.

alex retitled this revision from MINC-127 Optimize "ord:UsingCreditCard" tag to MINC-127 Optimize "ord_UsingCreditCard" tag.Jul 16 2016, 6:33 AM

Revision Contents
Changeset List

			Path	Packages
M			modules/in-commerce/units/orders/orders_tag_processor.php (46 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	213	16206		Jun 10 2015, 10:08 AM	★	★
Diff 2	214	16206	Requested changes	Jun 10 2015, 10:21 AM	★	★
Diff 3	215	16206	new getPrimaryPaymentType method	Jun 10 2015, 10:55 AM	★	★
Diff 4	294	16244	Commit rMINC16248	Sep 2 2015, 3:55 PM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 214

View Options

modules/in-commerce/units/orders/orders_tag_processor.php

MINC-127 Optimize "ord_UsingCreditCard" tagClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 214

modules/in-commerce/units/orders/orders_tag_processor.php

MINC-127 Optimize "ord_UsingCreditCard" tag
ClosedPublic
Actions

Revision Contents
Changeset List