Page MenuHomeIn-Portal Phabricator

INP-1511 - Add "export presets" support for category items export dialogs
ClosedPublic

Authored by erik on Nov 2 2015, 9:47 AM.

Details

Summary

Added export presets for category items.

Test Plan
NOTE: Please repeat below steps for orders, products, links and articles export.
  1. make export with "Save/Update Export Preset" checked and "Export Preset Title" entered
  2. confirm, that on next export new export preset with entered "Export Preset Title" is available and working (chages export configuration on selection)
  3. press "Delete" button when some export preset is chosen and press "OK" in confirmation window
  4. close export window
  5. confirm, that on next export deleted preset is not available

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.3.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 240
Build 240: arc lint + arc unit

Event Timeline

erik updated this revision to Diff 396.Nov 2 2015, 9:47 AM
erik retitled this revision from to INP-1511 Presets for category items export.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik added 1 JIRA issue(s): INP-1511.
erik edited the test plan for this revision. (Show Details)Nov 3 2015, 5:16 AM
alex requested changes to this revision.Nov 3 2015, 5:51 AM
alex edited edge metadata.
alex added inline comments.
core/admin_templates/incs/form_blocks.tpl
1281

Please incorporate block, that shows available/used export columns in here.


This block uses lists of available & used columns defined in another block, which isn't guaranteed to be present.

1359

Wrap this with document.ready.


The above code doesn't work, because field is added after this code is executed.

1360

Please remove this.


Not needed blank line.

1362

Please remove this.


Not needed blank line.

core/kernel/db/cat_event_handler.php
2886–2897 ↗(On Diff #396)

Please make this change in the corresponding unit configs instead.


The affected unit configs can be changed directly, because added virtual fields doesn't contain any dynamic information in their declaration.

This revision now requires changes to proceed.Nov 3 2015, 5:51 AM
erik updated this revision to Diff 398.Nov 3 2015, 9:28 AM
erik edited edge metadata.

Made required fixes

alex requested changes to this revision.Nov 5 2015, 5:15 AM
alex edited edge metadata.
alex added inline comments.
modules/in-commerce/units/products/products_config.php
632–645

Please add fields after existing export related fields, instead of creating new field group.

P.S.
This is how it was done in the orders_config.php file from where you've copied fields originally.

modules/in-link/units/links/links_config.php
573–586

Please add fields after existing export related fields, instead of creating new field group.

P.S.
This is how it was done in the orders_config.php file from where you've copied fields originally.

modules/in-news/units/articles/articles_config.php
514–527

Please add fields after existing export related fields, instead of creating new field group.

P.S.
This is how it was done in the orders_config.php file from where you've copied fields originally.

This revision now requires changes to proceed.Nov 5 2015, 5:15 AM
erik updated this revision to Diff 401.Nov 5 2015, 9:09 AM
erik edited edge metadata.

Moved configuration fields ro requested places

erik updated this revision to Diff 402.Nov 5 2015, 10:31 AM
erik edited edge metadata.

Removed excessive IncludeFieldTitles checkbox.

alex accepted this revision.Nov 5 2015, 10:52 AM
alex edited edge metadata.
This revision is now accepted and ready to land.Nov 5 2015, 10:52 AM
This revision was automatically updated to reflect the committed changes.
alex edited edge metadata.Mar 10 2016, 5:38 AM
alex added a project: Restricted Project.
alex retitled this revision from INP-1511 Presets for category items export to INP-1511 - Add "export presets" support for category items export dialogs.Jul 15 2016, 2:31 PM