Page MenuHomeIn-Portal Phabricator

MINC-139 - Remove product object after Shopping Cart printing
ClosedPublic

Authored by glebs on Jan 13 2016, 3:45 AM.

Details

Test Plan
NOTE: All tests should be done in advanced theme
NOTE: Do not apply patch before Preparation

Preparation

  1. Add 1-2 products with prices into Products section. Enable them - you should see them on website.
  2. Open the themes/advanced/in-commerce/checkout/shop_cart.tpl template for editing:
  3. Locate <inp2:ord_PrintCart ... line
  4. Add this code after it:
<inp2:m_DefineElement name="test_element">
    <inp2:Field name="Name"/>
</inp2:m_DefineElement>

<inp2:p_PrintList render_as="test_element" per_page="2"/><br/>
  1. Save changes
  2. Go to products list page and add some product into shopping cart
  3. you should get error in debugger:
Exception: Query method is called in class ProductsItem for prefix p in ...\core\kernel\db\dbitem.php on line 1506

Testing

  1. Apply patch
  2. Reload shopping cart page - error should be gone

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 280
Build 280: arc lint + arc unit

Event Timeline

glebs updated this revision to Diff 436.Jan 13 2016, 3:45 AM
glebs retitled this revision from to MINC-139 Remove project object after Shopping Cart printing.
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added 1 JIRA issue(s): MINC-139.
glebs edited the test plan for this revision. (Show Details)Jan 13 2016, 3:46 AM
glebs edited edge metadata.
alex edited the test plan for this revision. (Show Details)Jan 13 2016, 5:11 AM
alex edited the test plan for this revision. (Show Details)Jan 13 2016, 5:16 AM
alex added a project: Restricted Project.Mar 10 2016, 5:11 AM
alex retitled this revision from MINC-139 Remove project object after Shopping Cart printing to MINC-139 Remove product object after Shopping Cart printing.Jul 16 2016, 6:30 AM
alex accepted this revision.Jul 28 2022, 3:19 AM
alex edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jul 28 2022, 3:19 AM
alex retitled this revision from MINC-139 Remove product object after Shopping Cart printing to MINC-139 - Remove product object after Shopping Cart printing.Aug 3 2022, 4:43 AM
This revision was automatically updated to reflect the committed changes.