Page MenuHomeIn-Portal Phabricator

INP-1532 Allow specifying scheduled time for Promo Blocks
ClosedPublic

Authored by erik on Mar 15 2016, 6:44 AM.

Details

Summary

Allowed specify scheduled time, comfigured specific time default values.

Test Plan
NOTE: Apply patch from D201 revision first.
  1. go to Website & ContentPromo BlocksDefault Group section
  2. click on "Add" button
  3. confirm that form opens and "Schedule ..." fields are empty
  4. click on "Schedule From" date picker icon
  5. confirm that picker opens and contains current date, but midnight time
  6. pick some date
  7. confirm that picker closes and chosen date placed in the input field
  8. click on date picker icon
  9. confirm that picker opens and contains previously picked date and time
  10. click on "Schedule To" date picker icon
  11. confirm that picker opens and contains current date, but "23:59" (or "11:59 PM" depending on regional settings) time
  12. pick some date
  13. confirm that picker closes and chosen date placed in the input field
  14. click on date picker icon
  15. confirm that picker opens and contains previously picked date and time
  16. input "from" date later than "to" date, press "Save" button
  17. confirm, that promo block is not saved and error is shown on "Schedule From" field

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.3.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 338
Build 338: arc lint + arc unit

Event Timeline

erik updated this revision to Diff 490.Mar 15 2016, 6:44 AM
erik retitled this revision from to INP-1532 Allow specifying scheduled time for Promo Blocks.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik added 1 JIRA issue(s): INP-1532.
alex edited the test plan for this revision. (Show Details)Mar 16 2016, 5:07 AM
alex requested changes to this revision.Mar 16 2016, 5:27 AM
alex edited edge metadata.
alex added inline comments.
core/units/promo_blocks/promo_block_eh.php
200–206
  1. This doesn't work as expected anymore. When following values are set I should see wrong interval error and shouldn't be allowed to save promo block changes:
    • Scheduled From to 03/16/2016 11:59:01 PM
    • Scheduled To to 03/16/2016 11:59:00 PM
  2. Change to this code fragment isn't covered by the test plan.
This revision now requires changes to proceed.Mar 16 2016, 5:27 AM
erik edited the test plan for this revision. (Show Details)Mar 16 2016, 6:50 AM
erik edited edge metadata.
erik updated this revision to Diff 492.Mar 16 2016, 6:54 AM
erik edited edge metadata.

Fixed bugs in displaying wrong date interval error.

alex requested changes to this revision.Mar 16 2016, 9:31 AM
alex edited edge metadata.

This is the last fixing round.

core/install/english.lang
1605

Since la_ToDateMustBeGreaterThanFromDate phrase wasn't even translated before this Differential Revision please do the following:

  1. delete this phrase (no migration script needed, because phrase is only added here)
  2. add la_error_WrongPromoBlockScheduleInterval phrase with "Scheduled To" date/time must be before "Scheduled From" translation
  3. use that phrase instead of la_ToDateMustBeGreaterThanFromDate in the unit config, when mapping wrong_date_interval error message
This revision now requires changes to proceed.Mar 16 2016, 9:31 AM
erik updated this revision to Diff 493.Mar 16 2016, 10:07 AM
erik edited edge metadata.

Changed error phrase

erik updated this revision to Diff 494.Mar 16 2016, 11:47 AM
erik edited edge metadata.

Removed excessive element from edit template

alex accepted this revision.Mar 17 2016, 6:32 AM
alex edited edge metadata.
This revision is now accepted and ready to land.Mar 17 2016, 6:32 AM
alex edited edge metadata.Mar 17 2016, 8:21 AM
alex added a project: Restricted Project.
This revision was automatically updated to reflect the committed changes.