Page MenuHomeIn-Portal Phabricator

INP-1655 - Improve "additional_title_render_as" parameter support in "combined_header" block
ClosedPublic

Authored by alex on Dec 2 2016, 3:03 AM.

Details

Test Plan

Part 1

  • in Admin Console
    1. go to ConfigurationAdvanced section
    2. uncheck Use Small Section Headers checkbox and save changes
    3. go to Website & ContentLabels & Phrases section
    4. confirm, that you see:
      • in heading: parent section icon and name
      • in blue bar: this section name
    5. go to ConfigurationAdvanced section
    6. check Use Small Section Headers checkbox and save changes
    7. go to Website & ContentLabels & Phrases section
    8. confirm, that you see:
      • in heading: nothing
      • in blue bar: {this section name} - {parent section name} (without braces)

Part 2

  • in IDE:
    1. open /core/admin_templates/languages/phrase_list.tpl file for editing
    2. before rendering of combined_header block add this: <inp2:m_DefineElement name="extra_heading"><td>extra heading</td></inp2:m_DefineElement>
    3. add additional_title_render_as="extra_heading" parameter, where combined_header block is rendered
  • in Admin Console
    1. go to ConfigurationAdvanced section
    2. uncheck Use Small Section Headers checkbox and save changes
    3. go to Website & ContentLabels & Phrases section
    4. confirm, that you see:
      • in heading on the left side: parent section icon and name
      • in heading on the right side: extra heading text
      • in blue bar: this section name
    5. go to ConfigurationAdvanced section
    6. check Use Small Section Headers checkbox and save changes
    7. go to Website & ContentLabels & Phrases section
    8. confirm, that you see:
      • in heading: extra heading text
      • in blue bar: {this section name} - {parent section name} (without braces)

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 611
Build 611: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 655.Dec 2 2016, 3:03 AM
alex retitled this revision from to INP-1655 - Improve "additional_title_render_as" parameter support in "combined_header" block.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1655.
erik requested changes to this revision.Dec 2 2016, 3:31 AM
erik edited edge metadata.

Not confirmed test Part2, in Admin Console, item N4 "in heading: parent section icon and name, and on next row extra heading text". In fact, extra heading text is on top, section header - next line after extra heading text - in reverse order from defined in test plan.

This revision now requires changes to proceed.Dec 2 2016, 3:31 AM
alex added a comment.Dec 2 2016, 5:00 AM

My bad. I haven't noticed, that:

  • there should be a TD in additional_title_render_as element itself
  • there should be a TABLE/TR around rendering of additional_title_render_as element

Will fix that.

alex edited the test plan for this revision. (Show Details)Jan 5 2017, 3:16 AM
alex edited edge metadata.
alex edited the test plan for this revision. (Show Details)Jan 5 2017, 3:21 AM
alex updated this revision to Diff 674.Jan 5 2017, 3:23 AM
alex edited edge metadata.

Changed additional_title_render_as block to be rendering as table cell.

alex updated this revision to Diff 675.Jan 5 2017, 3:23 AM
alex edited edge metadata.

Removed debugging code.

erik accepted this revision.Jan 10 2017, 4:49 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Jan 10 2017, 4:49 AM
This revision was automatically updated to reflect the committed changes.