Page MenuHomeIn-Portal Phabricator

INP-1682 - Make "kFormatter::TypeCast" to return "false" when value (not type) is changed
ClosedPublic

Authored by alex on Feb 24 2017, 3:02 AM.

Details

Test Plan

Test values to be used below: text, 5, 5.0, 5.2, 5.20

Part 1

  • in IDE: change data type for Qty field of widget unit to integer, int
  • in Admin Console:
    1. go to CustomWidgets section
    2. press Add button on toolbar
    3. for each of test values from above:
      1. enter test value in Qty field
      2. press Save button on the toolbar
      3. confirm, that form submit happened and you're returned back with validation error (not necessarily on Qty field)
      4. confirm, that value in the Qty field input stayed as-is
      5. confirm, that for text, 5.2 and 5.20 values (not other values) the validation error in Qty field was reported

Part 2

  • in IDE: change data type for Qty field of widget unit to float, double
  • in Admin Console:
    1. go to CustomWidgets section
    2. press Add button on toolbar
    3. for each of test values from above:
      1. enter test value in Qty field
      2. press Save button on the toolbar
      3. confirm, that form submit happened and you're returned back with validation error (not necessarily on Qty field)
      4. confirm, that value in the Qty field input stayed as-is
      5. confirm, that for text value (not other values) the validation error in Qty field was reported

Part 3

  • in IDE: change data type for Qty field of widget unit to string
  • in Admin Console:
    1. go to CustomWidgets section
    2. press Add button on toolbar
    3. for each of test values from above:
      1. enter test value in Qty field
      2. press Save button on the toolbar
      3. confirm, that form submit happened and you're returned back with validation error (not necessarily on Qty field)
      4. confirm, that value in the Qty field input stayed as-is
      5. confirm, that none of test values have triggered the validation error in Qty field

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 683
Build 683: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 704.Feb 24 2017, 3:02 AM
alex retitled this revision from to INP-1682 - Make "kFormatter::TypeCast" to return "false" when value (not type) is changed.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1682.
erik accepted this revision.Apr 5 2017, 5:28 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Apr 5 2017, 5:28 AM
This revision was automatically updated to reflect the committed changes.