Differential D307

INP-1704 - Use strict comparison in "Session::NeedQueryString" method
ClosedPublic
Actions

Authored by alex on May 17 2017, 5:06 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16586: Fixes INP-1704 - Use strict comparison in "Session::NeedQueryString" method

Test Plan

on Front-End:
1. confirm, that none of the link urls (check few urls in random places) have ?sid=... in them
in IDE:
1. open /index.php for editing
2. add $application->Session->CachedNeedQueryString = true; line after $application->Init(); line
3. save changes
on Front-End:
1. confirm, that all of the link urls (check few urls in random places) have ?sid=... in them
in IDE:
1. open /index.php for editing
2. replace $application->Session->CachedNeedQueryString = true; line with $application->Session->CachedNeedQueryString = false;
3. save changes
on Front-End:
1. confirm, that none of the link urls (check few urls in random places) have ?sid=... in them

Diff Detail

Repository

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 730
Build 730: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 744.May 17 2017, 5:06 AM

alex retitled this revision from to INP-1704 - Use strict comparison in "Session::NeedQueryString" method.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1704.

Herald added a reviewer: erik. · View Herald TranscriptMay 17 2017, 5:06 AM

alex mentioned this in D308: INP-1705 - Make "Session::NeedQueryString" method always return "false" when in CLI.May 17 2017, 5:31 AM

alex edited edge metadata.May 17 2017, 5:43 AM

alex added a project: Restricted Project.

erik accepted this revision.May 17 2017, 5:57 AM

erik edited edge metadata.

This revision is now accepted and ready to land.May 17 2017, 5:57 AM

Closed by commit rINP16586: Fixes INP-1704 - Use strict comparison in "Session::NeedQueryString" method (authored by alex). · Explain WhyJul 18 2017, 6:41 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 744

core/kernel/session/session.php

Loading...