Page MenuHomeIn-Portal Phabricator
Differential D309

INP-1706 - Generate assets during deployment
ClosedPublic
Actions

Authored by alex on May 20 2017, 4:06 AM.

Details

Reviewers
erik
Commits
rINP16588: Fixes INP-1706 - Generate assets during deployment
Test Plan
NOTE: Test both clean install and upgrade.
  • in Admin Console:
    1. go to Tools → System Tools section
    2. confirm, that Dump Assets sub-section with Dump button is present in Project Deployment section
  • in VM:
    1. delete all js/css files in /system/cache folder
  • in Admin Console:
    1. press Dump button in Dump Assets sub-section in Project Deployement section
  • in VM:
    1. confirm, that c_* files js/css where created in /system/cache folder
  • in VM:
    1. delete all js/css files in /system/cache folder
  • in Admin Console:
    1. press Deploy button
    2. confirm, that Dumping Assets ... OK text was displayed on black background
  • in VM:
    1. confirm, that c_* files js/css where created in /system/cache folder
  • in Admin Console:
    1. confirm, that description in Deploy Changes sub-section tells, that assets will be dumped during deployment
    2. press Synchronize button
    3. confirm, that Dumping Assets ... OK text wasn't displayed on black background
  • in VM:
    1. remember list of js/css files in /system/cache folder
  • in Admin Console:
    1. go to Tools → System Tools section
    2. press Refresh button in Refresh Theme Files sub-section in Templates section
  • in VM:
    1. confirm, that list of js/css files in /system/cache folder haven't changed

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Can't fix without causing large merge conflict later on.
SeverityLocationCodeMessage
Errorcore/units/admin/admin_events_handler.php:509PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCapsCodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
Errorcore/units/helpers/deployment_helper.php:357PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.PrivateNoUnderscoreCodingStandard.NamingConventions.ValidFunctionName.PrivateNoUnderscore
Errorcore/units/helpers/minifiers/minify_helper.php:198PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/helpers/minifiers/minify_helper.php:206PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Unit
No Unit Test Coverage
Build Status
Buildable 732
Build 732: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 746.May 20 2017, 4:06 AM
alex retitled this revision from to INP-1706 - Generate assets during deployment.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1706.
alex edited edge metadata.May 21 2017, 2:22 PM
alex added a project: Restricted Project.
erik accepted this revision.May 26 2017, 5:55 AM
erik edited edge metadata.
This revision is now accepted and ready to land.May 26 2017, 5:55 AM
Closed by commit rINP16588: Fixes INP-1706 - Generate assets during deployment (authored by alex). · Explain WhyJul 19 2017, 2:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 174616543May 20 2017, 4:06 AM
★
★
Diff 279516587rINP16588Jul 19 2017, 2:36 AM
★
★

Diff 746

View Options

core/admin_templates/tools/system_tools.tpl

Loading...
View Options

core/install/english.lang

Loading...
View Options

core/install/upgrades.sql

Loading...
View Options

core/units/admin/admin_events_handler.php

Loading...
View Options

core/units/helpers/deployment_helper.php

Loading...
View Options

core/units/helpers/minifiers/minify_helper.php

Loading...
View Options

core/units/helpers/themes_helper.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server