Unexpected output: Affected paths: relative - resubmit patch.
⚙ D260 INP-1592 - Allow specifying "robots" meta tag for pages
Page MenuHomeIn-Portal Phabricator
Differential D260

INP-1592 - Allow specifying "robots" meta tag for pages
Needs RevisionPublic
Actions

Authored by • vjacheslavv on Nov 16 2016, 12:05 PM.

Details

Reviewers
alex
Test Plan
  1. on Front-End
    • visit homepage
    • do View Source
    • confirm, that no <meta name="robots" ...> tag is present
  1. in Admin Console
    • go to Website & Content → Structure & Data section
    • click on Sections tab
    • open a Home category for editing
    • confirm, that Meta Robots Exclusions field is visible
    • select several options in Meta Robots Exclusions field and save changes
  1. on Front-End
    • visit homepage
    • do View Source
    • confirm, that <meta name="robots" ...> tag is present and in content="..." part the comma-separated list of selected robot exclusions is shown

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.3.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 528
Build 528: arc lint + arc unit

Event Timeline

• vjacheslavv updated this revision to Diff 615.Nov 16 2016, 12:05 PM
• vjacheslavv retitled this revision from to INP-1592 - Allow specifying "robots" meta tag for pages.
• vjacheslavv updated this object.
• vjacheslavv edited the test plan for this revision. (Show Details)
• vjacheslavv added 1 JIRA issue(s): INP-1592.
alex requested changes to this revision.Nov 20 2016, 1:14 PM
alex edited edge metadata.
alex added inline comments.
core/admin_templates/categories/categories_edit.tpl
190

Please add la_fld_MetaRobotsExclusions phrase.

New phrase is used, but not added into /core/install/english.lang file.

core/install/install_schema.sql
600

Move the MetaRobotsExclusions column after MetaDescription column.

Related fields must be located nearby.

core/install/upgrades.sql
3052

Move the MetaRobotsExclusions column after MetaDescription column.

Related fields must be located nearby.

core/units/categories/categories_config.php
433

Add 'multiple' => 1 field option.

This option indicates to kOptionsFormatter, that multiple values can be selected in this field.

core/units/categories/categories_tag_processor.php
1395
  1. rename $val to $value
  2. rename GetDbField into GetDBField
  1. CS: variable name is too short
  2. method name, when using, must match method name in declaration (yes I know, that PHP ignores that)
core/units/structure/structure_config.php
221

Add 'multiple' => 1 field option.

This option indicates to kOptionsFormatter, that multiple values can be selected in this field.

This revision now requires changes to proceed.Nov 20 2016, 1:14 PM

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 161516431Nov 16 2016, 12:05 PM
★
★

Diff 615

View Options

core/admin_templates/categories/categories_edit.tpl

Loading...
View Options

core/install/install_schema.sql

Loading...
View Options

core/install/upgrades.sql

Loading...
View Options

core/units/categories/categories_config.php

Loading...
View Options

core/units/categories/categories_tag_processor.php

Loading...
View Options

core/units/structure/structure_config.php

Loading...
View Options

themes/default/elements/html_head.elm.tpl

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server