Page MenuHomeIn-Portal Phabricator
  • Changed Files
  • branches/5.2.x/core/admin_templates/js/uploader/uploader.js
Differential D273

INP-1659 - Add HTML5 runtime to Plupload options
ClosedPublic
Actions

Authored by alex on Dec 27 2016, 5:08 AM.

Details

Reviewers
erik
Commits
rINP16558: Fixes INP-1659 - Add HTML5 runtime to Plupload options
Test Plan
NOTE: Use BrowserStack or similar service to test on different web browser versions.

Testing Flash uploader

  1. open Internet Explorer 8 web browser
  2. login to Admin Console
  3. go to Custom → Widgets section
  4. upload large (several MB in size) image into Image field
  5. confirm, that:
    • upload progress bar was displayed
    • image was uploaded
    • inspecting over Browse button would show that SWF file is placed over it

Testing HTML5 uploader

  1. open Internet Explorer 10 web browser
  2. login to Admin Console
  3. go to Custom → Widgets section
  4. upload large (several MB in size) image into Image field
  5. confirm, that:
    • upload progress bar was displayed
    • image was uploaded
    • inspecting over Browse button won't show that SWF file is placed over it

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 665.Dec 27 2016, 5:08 AM
alex retitled this revision from to INP-1659 - Add HTML5 runtime to Plupload options.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1659.
erik accepted this revision.Dec 28 2016, 5:07 AM
erik edited edge metadata.

Tested all with IE10. Tested with IE8, as browser mode of IE10 (through IE8 mode selection in developer tools).

This revision is now accepted and ready to land.Dec 28 2016, 5:07 AM
alex requested a review of this revision.Dec 28 2016, 5:29 AM
alex edited edge metadata.

That won't do unfortunately. You need to test in real browser, not just a compatibility mode.

If you don't have BrowserStack account credentials to perform the tests, then ask me directly (over Skype) and I'll give them to you.

alex edited edge metadata.Dec 28 2016, 9:13 AM
alex added a project: Restricted Project.
erik accepted this revision.Jan 4 2017, 4:09 AM
erik edited edge metadata.

Tasted also on https://www.browserstack.com (IE8 part)

This revision is now accepted and ready to land.Jan 4 2017, 4:09 AM
Closed by commit rINP16558: Fixes INP-1659 - Add HTML5 runtime to Plupload options (authored by alex). · Explain WhyJul 16 2017, 7:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 166516502Dec 27 2016, 5:08 AM
★
★
Diff 276916557rINP16558Jul 16 2017, 7:53 AM
★
★

Diff 769

View Options

branches/5.2.x/core/admin_templates/js/uploader/uploader.js

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server