Page MenuHomeIn-Portal Phabricator

INP-1782 Allow multiple sections from single unit to have separate permissions
Needs ReviewPublic

Authored by erik on Mar 11 2020, 1:46 PM.

Details

Reviewers
alex
Summary

Changes to have separate permissions for different sections under one unit.

Test Plan
  1. Login as administrative user to the adm.console
  2. Go to User ManagementGroups section
  3. Edit admin group's permissions, check view permission for User Management -> Administrators and uncheck view permission for User Management -> Users section, save.
  4. Confirm that Users section disappeared, and Administrators section is visible
  5. Open admin group's permissions, confirm that checkboxes, changed before, has right values - checked for Administrators, and unchecked for users.

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Full files re-formatting is not part of this task.
SeverityLocationCodeMessage
Errorcore/kernel/utility/event.php:434PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/units/admin/admin_events_handler.php:148PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/units/admin/admin_events_handler.php:148PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/units/admin/admin_tag_processor.php:263PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errorcore/units/admin/admin_tag_processor.php:263PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errorcore/units/admin/admin_tag_processor.php:278PHPCS.E.CodingStandard.ControlStructures.ControlSignature.FoundCodingStandard.ControlStructures.ControlSignature.Found
Errorcore/units/admin/admin_tag_processor.php:280PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errorcore/units/admin/admin_tag_processor.php:280PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errorcore/units/admin/admin_tag_processor.php:280PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/units/admin/admin_tag_processor.php:280PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/units/admin/admin_tag_processor.php:280PHPCS.E.Generic.ControlStructures.InlineControlStructure.NotAllowedGeneric.ControlStructures.InlineControlStructure.NotAllowed
Errorcore/units/admin/admin_tag_processor.php:361PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.NoLineBeforeOpenCodingStandard.WhiteSpace.ControlStructureSpacing.NoLineBeforeOpen
Errorcore/units/admin/admin_tag_processor.php:361PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/units/admin/admin_tag_processor.php:361PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/units/helpers/sections_helper.php:51PHPCS.E.CodingStandard.Commenting.FunctionComment.MissingCodingStandard.Commenting.FunctionComment.Missing
Errorcore/units/helpers/sections_helper.php:147PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/units/helpers/sections_helper.php:147PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/units/helpers/sections_helper.php:411PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/units/helpers/sections_helper.php:411PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/units/helpers/sections_helper.php:455PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBraceCodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace
Unit
No Unit Test Coverage
Build Status
Buildable 951
Build 951: arc lint + arc unit

Event Timeline

erik created this revision.Mar 11 2020, 1:46 PM
erik requested review of this revision.Mar 11 2020, 1:46 PM