Page MenuHomeIn-Portal Phabricator

INP-1783 - Add "checkboxes" control type for configuration settings
AcceptedPublic

Authored by alex on May 13 2020, 9:12 AM.

Details

Reviewers
erik
Test Plan
  1. login to Admin Console
  2. go to {Configuration > Website > General} section
  3. click Edit link next to Website name setting
  4. change Input Type field value to Checkboxes
  5. specify 1=+one||2=+two||3=+three in the List of Values field
  6. save changes
  7. confirm, that 3 unchecked checkboxes configured above (one, two and three) are shown
  8. check any 1 or 2 checkboxes and save changes
  9. confirm, that checkboxes stayed checked after page is reloaded
  10. uncheck all checkboxes
  11. confirm, that checkboxes stayed unchecked after page is reloaded

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.3.x
Lint
Lint ErrorsExcuse: Not fixing code, that wasn't added in this task.
SeverityLocationCodeMessage
Errorcore/kernel/db/db_tag_processor.php:2161PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/kernel/db/db_tag_processor.php:2161PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/units/configuration/configuration_config.php:104PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/configuration/configuration_config.php:104PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Warningcore/units/configuration/configuration_config.php:105PHPCS.W.CodingStandard.Arrays.Array.NoLastCommaCodingStandard.Arrays.Array.NoLastComma
Unit
No Unit Test Coverage
Build Status
Buildable 954
Build 954: arc lint + arc unit

Event Timeline

alex created this revision.May 13 2020, 9:12 AM
alex requested review of this revision.May 13 2020, 9:12 AM
alex added a project: Restricted Project.May 13 2020, 9:13 AM
erik accepted this revision.Aug 17 2020, 1:22 PM
This revision is now accepted and ready to land.Aug 17 2020, 1:22 PM