Unexpected output:

Affected paths: relative - resubmit patch.

⚙ D445 INP-1840 - Reset form scroll prior to window resizing handling

Differential D445

INP-1840 - Reset form scroll prior to window resizing handling
ClosedPublic
Actions

Authored by alex on Apr 11 2023, 9:02 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16773: Fixes INP-1840 - Reset form scroll prior to window resizing handling

Test Plan

in IDE:
1. open the core/admin_templates/js/forms.js file for editing
2. add console.log('resizing'); after Form.reizeTimeoutId = setTimeout(function () { line
3. save changes
in Web Browser:
1. login to the Admin Console
2. go to the User Management → Groups section
3. open any group for editing
4. go to the Permissions tab
5. open Web Browser inspector in a separate window (so that it won't reduce editing window height) on the Console tab and clear it's contents
6. scroll to the end of the editing window
7. confirm, that the Admin Skins section is visible
8. scroll to the middle of the editing window
9. increase the size of the editing window
10. confirm, that a single resizing text was added to the Console tab of the Inspector window
11. scroll to the end of the editing window
12. confirm, that the Admin Skins section is visible

Diff Detail

Repository

Branch

/in-portal/branches/5.2.x

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1185
Build 1185: arc lint + arc unit

Event Timeline

alex created this revision.Apr 11 2023, 9:02 AM

Herald added a reviewer: erik. · View Herald TranscriptApr 11 2023, 9:02 AM

alex requested review of this revision.Apr 11 2023, 9:02 AM

Harbormaster completed remote builds in B1185: Diff 1146.Apr 11 2023, 9:02 AM

alex added a project: Restricted Project.Apr 11 2023, 9:03 AM

erik accepted this revision.Apr 11 2023, 11:50 AM

This revision is now accepted and ready to land.Apr 11 2023, 11:50 AM

Closed by commit rINP16773: Fixes INP-1840 - Reset form scroll prior to window resizing handling (authored by alex, committed by ). · Explain WhyNov 22 2023, 2:45 AM

This revision was automatically updated to reflect the committed changes.

alex edited the test plan for this revision. (Show Details)Jan 16 2024, 6:34 AM

alex edited the test plan for this revision. (Show Details)Jan 16 2024, 6:51 AM

alex edited the test plan for this revision. (Show Details)Jan 16 2024, 6:53 AM

alex added a child revision: D460: INP-1840 - Reset form scroll prior to window resizing handling (bugfix).Jan 16 2024, 7:01 AM

alex mentioned this in D460: INP-1840 - Reset form scroll prior to window resizing handling (bugfix).Jan 16 2024, 7:03 AM

alex edited the test plan for this revision. (Show Details)

Revision Contents
Changeset List

Diff 1146

core/admin_templates/js/forms.js

Loading...