Page MenuHomeIn-Portal Phabricator

INP-1895 Ensure consistent return type of the "kTempTablesHandler::CloneItems" method
Needs ReviewPublic

Authored by erik on Wed, Jan 29, 10:24 AM.

Details

Reviewers
alex
Summary

done fix to ensure right return type

Test Plan

Test Code

/** @var kDBItem $object */
$object = $event->getObject();
$object->SetError('CouponId', 'required');

Test

  1. Login to adm.console
  2. Go to the E-commerceDiscounts & Certificates section, go to the Coupons tab
  3. Create coupon record with records on Items tab (enough to have one record, produced with "Entire Order" button)
  4. Edit coupons_event_handler.php - add test code in the OnBeforeItemCreate, after parent method call.
  5. Go to the E-commerceDiscounts & Certificates section, go to the Coupons tab
  6. Select some coupon record and press "Clone" toolbar button
  7. Go to the Logs & ReportsSystem Log section
  8. Confirm that in the system log is not present notice like this: "Undefined index: coup.-item";
  9. Remove test code from coupons_event_handler.php

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11060
Build 3760: arc lint + arc unit

Event Timeline

erik created this revision.Wed, Jan 29, 10:24 AM
erik requested review of this revision.Wed, Jan 29, 10:24 AM
erik edited the test plan for this revision. (Show Details)Wed, Jan 29, 10:26 AM
erik edited the test plan for this revision. (Show Details)
alex edited the test plan for this revision. (Show Details)Wed, Jan 29, 10:59 AM