Page MenuHomeIn-Portal Phabricator

INP-1899 Preserve original formatting of multi-line error messages/exceptions in Debugger
Needs ReviewPublic

Authored by erik on Wed, Feb 5, 4:40 AM.

Details

Reviewers
alex
Summary

done stack trace formatting for fatal error cases

Test Plan

Preparations

  1. ensure that system log is enabled ($_CONFIG['Misc']['EnableSystemLog'] = '1'; in the config.php).
  2. add code $response = null; $headers = $response->getHeaders(); to the kLogger::prepare method.
  3. add code trigger_error('cause of kLogger::prepare invocation.'); to the UsersEventHandler::SetCustomQuery.

Test

  1. login to the adn.console
  2. go to the User ManagementUsers section
  3. confirm, that "Stack trace" info is shown in the debugger, and this info is properly formatted - each call info is shown on separate line

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: all code style fixes is not part of this task
SeverityLocationCodeMessage
Errorcore/kernel/utility/debugger.php:1914PHPCS.E.CodingStandard.NamingConventions.ValidVariableName.NotSnakeCapsCodingStandard.NamingConventions.ValidVariableName.NotSnakeCaps
Errorcore/kernel/utility/debugger.php:1918PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/kernel/utility/debugger.php:1918PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 11061
Build 3761: arc lint + arc unit

Event Timeline

erik created this revision.Wed, Feb 5, 4:40 AM
erik requested review of this revision.Wed, Feb 5, 4:40 AM
erik edited the test plan for this revision. (Show Details)Wed, Feb 5, 4:42 AM
erik edited the test plan for this revision. (Show Details)