Page MenuHomeIn-Portal Phabricator

INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available
Needs RevisionPublic

Authored by erik on Feb 5 2025, 4:58 AM.

Details

Reviewers
alex
Summary

prevented unexisting object usage attempt

Test Plan

Test code

$this->_logger->addRequestData();

Test

  1. add test code to the kApplication::Init method, before HttpQuery property initialization
  2. login to the adn.console
  3. go to the User ManagementUsers section
  4. confirm, that users grid is shown without any errors/notices

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11062
Build 3762: arc lint + arc unit

Event Timeline

erik created this revision.Feb 5 2025, 4:58 AM
erik requested review of this revision.Feb 5 2025, 4:58 AM
erik edited the test plan for this revision. (Show Details)Feb 5 2025, 4:59 AM
erik edited the test plan for this revision. (Show Details)
erik edited the test plan for this revision. (Show Details)Feb 5 2025, 5:02 AM
alex requested changes to this revision.EditedWed, Apr 30, 4:30 AM

Please:

  1. resubmit from the 5.3.x branch, because an associated Jira task is for the 5.3.x branch as well.
  2. (test plan only tests 50% of changed code) improve test plan by checking, that request header logging still works, when HttpQuery is present
This revision now requires changes to proceed.Wed, Apr 30, 4:30 AM