Page MenuHomeIn-Portal Phabricator

INP-1921 - Improve Change Log performance
AcceptedPublic

Authored by alex on Wed, Jul 30, 5:43 AM.

Details

Reviewers
erik
Test Plan
  1. login to Admin Console
  2. go to the ConfigurationWebsiteAdvanced section
  3. enable the Track database changes to change log system setting
  4. save changes
  5. logout & login again
  6. perform any actions, that should result in a database change trackable via a Changes Log section
  7. go to the Logs & ReportsChanges Log section
  8. confirm, that:
    • your actions have resulted in records being created in this section
    • the grid filter dropdowns for the MasterPrefix and Prefix columns are not empty
    • the grid filter dropdowns for the MasterPrefix and Prefix columns contain translated/untranslated phrases that built like la_prefix_{column_value_here} (no braces)
    • the column values for the MasterPrefix and Prefix columns contain translated/untranslated phrases that built like la_prefix_{column_value_here} (no braces)

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Unrelated
SeverityLocationCodeMessage
Errorcore/units/logs/change_logs/change_logs_config.php:108PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/change_logs/change_logs_config.php:108PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/change_logs/change_logs_config.php:115PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/change_logs/change_logs_config.php:115PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 11115
Build 3815: arc lint + arc unit

Event Timeline

alex created this revision.Wed, Jul 30, 5:43 AM
alex requested review of this revision.Wed, Jul 30, 5:43 AM
erik accepted this revision.Thu, Jul 31, 5:30 AM
This revision is now accepted and ready to land.Thu, Jul 31, 5:30 AM