Page MenuHomeIn-Portal Phabricator

MINC-211 Remove "TitleField" option for the di/coupi/api units
Needs RevisionPublic

Authored by erik on Thu, Jul 31, 5:51 AM.

Details

Reviewers
alex
Summary

removed excessive TitleField key from discount items configuration

Test Plan
  1. login to the adm. console
  2. go to the E-commerceDiscounts & Certificates section
  3. create new discount record, with some sub-records on the Items tab
  4. go to the Logs & ReportsSystem Log section
  5. confirm that no record with warning 'Field "Name" is not defined in "di" unit config' appeared in the System Log
  6. confirm that no record with notice 'Undefined index: Name' appeared in the System Log

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11117
Build 3817: arc lint + arc unit

Event Timeline

erik created this revision.Thu, Jul 31, 5:51 AM
erik requested review of this revision.Thu, Jul 31, 5:51 AM
erik edited the test plan for this revision. (Show Details)Thu, Jul 31, 5:51 AM
alex retitled this revision from MINC-211 Fix discount items configuration to MINC-211 Remove "TitleField" option for the di/coupi/api units.Fri, Aug 1, 3:31 AM
alex requested changes to this revision.EditedFri, Aug 1, 3:36 AM
  1. I've noticed, that the same issue happens also with coupi and api units of the In-Commerce. Please expand the Differential Revision code/test plan to cover them as well.
  2. I've noticed, that you're testing, that notice is gone, but not testing that item adding code still works. Please test that as well.
  3. I've also renamed the task. Please rename your changelist in the PhpStorm to avoid accidental Differential Revision rename on patch update.
This revision now requires changes to proceed.Fri, Aug 1, 3:36 AM