Page MenuHomeIn-Portal Phabricator

INP-1927 Support "tinyint" data type in Table Structure Generator
ClosedPublic

Authored by erik on Thu, Sep 25, 12:32 PM.

Details

Summary

fixed tinyint column processing for case when length is empty

Test Plan
IMPORTANT: Test with MySQL 8.x.

Preparations

Run the following SQL to create a test table (replace inp_ prefix with the current system table prefix).

CREATE TABLE `inp_TestTinyInt` (
  `ColumnNone` tinyint DEFAULT NULL,
  `Column3` tinyint(3) DEFAULT NULL
);

Testing

  1. use the “Show Structure” button in the ToolsSystem Tools section on TestTinyInt table
  2. confirm that both columns have “kOptionsFormatter” assigned to them in the unit config field declaration

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

erik created this revision.Thu, Sep 25, 12:32 PM
erik requested review of this revision.Thu, Sep 25, 12:32 PM
erik edited the test plan for this revision. (Show Details)Thu, Sep 25, 12:36 PM
alex accepted this revision.Mon, Oct 6, 3:31 AM
alex edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Mon, Oct 6, 3:31 AM
This revision was automatically updated to reflect the committed changes.