Page MenuHomeIn-Portal Phabricator

INP-1928 - Automatic Scheduled Task creation protection
ClosedPublic

Authored by alex on Thu, Oct 23, 10:31 AM.

Details

Test Plan

Part 1 (testing with path applied)

  • in Admin Console:
    1. login to the Admin Console
    2. go to the ConfigurationWebsiteScheduled Tasks section
    3. delete any scheduled task, but remember which one
  • in DB:
    1. rename any of the non-critical DB columns (e.g. SiteDomainLimitation) in the ScheduledTasks table by adding _ in front of it's name
  • in Admin Console:
    1. go to the ToolsSystem Tools section
    2. trigger Unit Config Cache rebuild by using the Reset button under the Reset Parsed and Cached System Data heading
    3. go to the ConfigurationWebsiteScheduled Tasks section
    4. confirm, that previously deleted scheduled task record was recreated
    5. restore original name of the above-renamed column

Part 2 (testing without patch applied)

  1. revert the patch, that was applied
  2. repeat the Part 1 plan
  3. (instead of original confirm, ...) confirm, that you'll get an exception about attempt use an absent column in the ScheduledTasks DB table

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Thu, Oct 23, 10:31 AM
alex requested review of this revision.Thu, Oct 23, 10:31 AM
erik accepted this revision.Thu, Oct 23, 10:45 AM
This revision is now accepted and ready to land.Thu, Oct 23, 10:45 AM
This revision was landed with ongoing or failed builds.Wed, Nov 5, 7:58 AM
This revision was automatically updated to reflect the committed changes.