Page MenuHomeIn-Portal Phabricator
Differential D550

INP-1931 - Color Log Level names in the System Log
AcceptedPublic
Actions

Authored by alex on Tue, Dec 16, 6:17 AM.

Details

Reviewers
erik
Test Plan

Preparations

  1. in phpMyAdmin create records for each LogLevel (from 1 to 7) in the SystemLog table

Test Plan

  1. login to Admin Console
  2. go to the Logs & Reports → System Log section
  3. confirm, that each of the above-created system log records has it's Log Level column value colored according to task description
  4. open each of records for editing/viewing
  5. confirm, that same coloring logic is applied there as well

Diff Detail

Repository
rINP In-Portal
Branch
branches/5.2.x
Lint
Lint ErrorsExcuse: Unrelated.
SeverityLocationCodeMessage
Errorcore/units/logs/system_logs/system_logs_config.php:211PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/system_logs/system_logs_config.php:211PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/system_logs/system_logs_config.php:212PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/system_logs/system_logs_config.php:212PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/system_logs/system_logs_config.php:213PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/system_logs/system_logs_config.php:213PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 11168
Build 3868: arc lint + arc unit

Event Timeline

alex created this revision.Tue, Dec 16, 6:17 AM
alex requested review of this revision.Tue, Dec 16, 6:17 AM
erik accepted this revision.Tue, Dec 16, 8:24 AM

All task-defined coloring is right.

Not defined specific color for "emergency" log level, and for this log level excessive html

style="color: ;"

is produced both in the grid and in the edit form.

This revision is now accepted and ready to land.Tue, Dec 16, 8:24 AM

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1141816863Tue, Dec 16, 6:17 AM
★
★

Diff 1418

View Options

core/admin_templates/logs/system_logs/system_log_edit.tpl

Loading...
View Options

core/admin_templates/logs/system_logs/system_log_list.tpl

Loading...
View Options

core/units/logs/system_logs/system_log_tp.php

Loading...
View Options

core/units/logs/system_logs/system_logs_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server