Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F803829
D468.id1208.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Wed, Feb 26, 8:59 AM
Size
2 KB
Mime Type
text/x-diff
Expires
Thu, Feb 27, 8:59 AM (7 h, 31 m)
Engine
blob
Format
Raw Data
Handle
576553
Attached To
D468: INP-1862 - Execute "lint" prior to deploy during the build
D468.id1208.diff
View Options
Index: branches/5.2.x/tools/build/targets/common.xml
===================================================================
--- branches/5.2.x/tools/build/targets/common.xml
+++ branches/5.2.x/tools/build/targets/common.xml
@@ -31,7 +31,7 @@
<target name="build" description="Builds a project" depends="init,verify,analyze"/>
- <target name="build-parallel" description="Builds a project (long targets executed in parallel)" depends="init,lint,tools-parallel,phpunit"/>
+ <target name="build-parallel" description="Builds a project (long targets executed in parallel)" depends="init,tools-parallel,phpunit"/>
<target name="tools-parallel" description="Run tools in parallel">
<parallel threadCount="2">
@@ -50,8 +50,8 @@
<!-- ### Verify code consistency
Make sure that our code is clean and functional. -->
- <target name="verify" description="Verify code consistency" depends="init,lint"/>
- <!--<target name="verify" description="Verify code consistency" depends="init,lint,phpunit"/>-->
+ <target name="verify" description="Verify code consistency" depends="init"/>
+ <!--<target name="verify" description="Verify code consistency" depends="init,phpunit"/>-->
<!-- ### Analyze code
@@ -69,7 +69,7 @@
<!-- ### PHP linting
Check files for syntax errors. -->
- <target name="lint" description="Perform syntax check of sourcecode files" depends="init">
+ <target name="lint" description="Perform syntax check of sourcecode files" depends="folders-create">
<phplint haltonfailure="true" deprecatedAsError="false" cachefile="${build.cache.dir}/phplint.txt">
<fileset refid="php.files"/>
</phplint>
Index: branches/5.2.x/tools/build/targets/deploy.xml
===================================================================
--- branches/5.2.x/tools/build/targets/deploy.xml
+++ branches/5.2.x/tools/build/targets/deploy.xml
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<project name="inc_deploy" default="build">
- <target name="deploy-ci" description="Deployment tasks, that are required after SVN checkout" depends="create-aliases">
+ <target name="deploy-ci" description="Deployment tasks, that are required after SVN checkout" depends="lint,create-aliases">
<property name="tools.dir" value="${base.dir}/tools"/>
<echo msg="Fixing shell scripts permissions under '/tools' folder"/>
Event Timeline
Log In to Comment